Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: merge RPC commitment types to avoid duplicates #64

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Feat: merge RPC commitment types to avoid duplicates #64

merged 1 commit into from
Jun 5, 2024

Conversation

merklefruit
Copy link
Collaborator

  • new types are declared in primitives and are shared in all parts of the sidecar, to avoid duplicates between the RPC and state modules

@merklefruit merklefruit requested a review from mempirate June 5, 2024 09:15
@merklefruit merklefruit self-assigned this Jun 5, 2024
mempirate
mempirate approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/sidecar/fallback-block to unstable June 5, 2024 12:10
@merklefruit merklefruit merged commit 57e8f94 into unstable Jun 5, 2024
@merklefruit merklefruit deleted the feat/merge-rpc-types branch June 5, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mempirate mempirate mempirate approved these changes

Assignees

@merklefruit merklefruit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merklefruit @mempirate