fix(bolt-sidecar): correctly get preconf gas limit from env

[estensen]

Currently we get BOLT_SIDECAR_GAS_LIMIT which is the gas limit for a single tx. It defaults to DEFAULT_GAS_LIMIT which is 30M. That means pricing input validation will not fail when trying to use more gas than what's left for preconfs in a block. Other valdiation might reject this earlier, but I'd like it to be rejected here as well.

I think it's confusing to have to ENV vars that do the same, so removed BOLT_SIDECAR_GAS_LIMIT and replace it with BOLT_SIDECAR_MAX_COMMITTED_GAS

[thedevbirb]

Good catch! A couple of minor questions

[thedevbirb]

Is this comment still relevant?

[estensen]

yes, currently only preconf_gas_limit is configurable

/// Other values used for validation.
#[derive(Debug)]
pub struct ValidationParams {
    pub preconf_gas_limit: u64,
    pub max_tx_input_bytes: usize,
    pub max_init_code_byte_size: usize,
}

impl ValidationParams {
    pub fn new(gas_limit: u64) -> Self {
        Self {
            preconf_gas_limit: gas_limit,
            max_tx_input_bytes: 4 * 32 * 1024,
            max_init_code_byte_size: 2 * 24576,
        }
    }
}

Haven't been able to review the usefulnes of the others yet, so will leave the TODO for now

[thedevbirb]

Do you think renaming the property block_gas_limit of validation_params to preconf_gas_limit enhances clarity?

[estensen]

yes, good idea
9cd5b9c

[mempirate]

Sorry about nitpicking the naming here, but can we change this to inclusion_gas_limit? If introduce new commitment types, or execution preconfs, the naming is less ambiguous. In general let's try to use inclusion commitment or something similar instead of preconf in the codebase

[estensen]

nitpicking is good 👑👑

[thedevbirb]

Last nit