chore(docker/holesky): cleanup docker compose files #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
force-pushed
the
lore/chore/docker-holesky
branch
from
dde0d67 to
d853ee8
Compare
mempirate
reviewed
Jan 10, 2025
testnets/holesky/docker-compose.yml
Outdated
| @@ -82,7 +76,7 @@ volumes: | |||
| driver: local | |||
|
|
|||
| networks: | |||
| bolt-default: | |||
| bolt-holesky-default: | |||
| driver: bridge | |||
There was a problem hiding this comment.
You will have to add name: bolt-holesky-default here. Otherwise docker compose will prefix it with some bs and the name will differ in docker-compose.pbs.yml
There was a problem hiding this comment.
Updated this to drop all references to custom networks, after internal discussion we will use host.docker.internal as DNS and adding:
extra_hosts:
- host.docker.internal:host-gatewayOn every service that needs to communicate with others which expose a port on the host machine
thedevbirb
force-pushed
the
lore/chore/docker-holesky
branch
from
18345c3 to
855c159
Compare
merklefruit
requested changes
Jan 11, 2025
thedevbirb
force-pushed
the
lore/chore/docker-holesky
branch
from
855c159 to
dc9b1f5
Compare
mempirate
approved these changes
Jan 13, 2025
merklefruit
approved these changes
Jan 13, 2025
thedevbirb
force-pushed
the
lore/chore/docker-holesky
branch
from
dc9b1f5 to
9f22d07
Compare
thedevbirb
force-pushed
the
lore/chore/docker-holesky
branch
from
9f22d07 to
65bb535
Compare
This is available on Linux on newer version of docker by adding extra_host: - host.docker.internal:host-gateway on services where you need to use that DNS to access the host machine
thedevbirb
force-pushed
the
lore/chore/docker-holesky
branch
from
65bb535 to
3eaddc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to align some diffs we have between the code on GitHub and our setup on remotebeast, so that we don't have conflicts and headaches when pulling new changes.
Changelog:
bolt-holesky-default