Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(holesky): Align CB config and env files #696

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix(holesky): Align CB config and env files #696

merged 3 commits into from
Jan 17, 2025

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Jan 17, 2025 •
edited
Loading

Stacked on #691

I had to remove the depends_on flag because the cb_signer container doesn't spin up correctly due to some config parsing error. Until that is fixed, we MUST not add this back as it will prevent the sidecar process from starting.

  • add BOLT_SIDECAR_OPERATOR_PRIVATE_KEY required option in bolt-sidecar.env
  • Align other missing/outdated vars from .env.example in bolt-sidecar.env
  • Update formatting of .env.example for readibility

@merklefruit merklefruit changed the base branch from unstable to lore/fix/holesky-cb-config January 17, 2025 11:40
@merklefruit merklefruit changed the title fix(holesky): cb config fix(holesky): Align CB config and env files Jan 17, 2025
@merklefruit merklefruit mentioned this pull request Jan 17, 2025
Merged
@merklefruit merklefruit marked this pull request as ready for review January 17, 2025 11:58
@merklefruit merklefruit requested a review from mempirate January 17, 2025 11:59
mempirate
mempirate approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thedevbirb thedevbirb merged commit fcde555 into lore/fix/holesky-cb-config Jan 17, 2025
3 checks passed
@thedevbirb thedevbirb deleted the nico/fix/cb-configs branch January 17, 2025 12:58
@merklefruit merklefruit mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mempirate mempirate mempirate approved these changes

@estensen estensen estensen approved these changes

@thedevbirb thedevbirb Awaiting requested review from thedevbirb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merklefruit @estensen @mempirate @thedevbirb