Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate generic signer in sidecar #88

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Integrate generic signer in sidecar #88

merged 5 commits into from
Jun 21, 2024

Conversation

thedevbirb
Copy link
Contributor

Closes #63. This PR introduces a generic BLS signer in the sidecar that could be obtained either by providing a private key or by integrating commit-boost

@thedevbirb thedevbirb added C: bolt-sidecar Component: bolt-sidecar T: feature Type: Feature labels Jun 17, 2024
@thedevbirb thedevbirb marked this pull request as ready for review June 17, 2024 16:08
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merklefruit included this from the commit-boost devnet branch, do you if we actually need it for the tests? To me it doesn't seems so but I want to be sure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I don't know if it makes sense to keep, because the interface of that file will most likely change before commit-boost has a stable release. Let's keep it out for now IMO

Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, after config file removed

@merklefruit merklefruit merged commit 9880b4d into unstable Jun 21, 2024
@merklefruit merklefruit deleted the feat/signer branch June 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-sidecar Component: bolt-sidecar T: feature Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate integrating commit-boost signing manager
2 participants