-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate generic signer in sidecar #88
Conversation
bolt-sidecar/bolt.config.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@merklefruit included this from the commit-boost devnet branch, do you if we actually need it for the tests? To me it doesn't seems so but I want to be sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I don't know if it makes sense to keep, because the interface of that file will most likely change before commit-boost has a stable release. Let's keep it out for now IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, after config file removed
Closes #63. This PR introduces a generic BLS signer in the sidecar that could be obtained either by providing a private key or by integrating commit-boost