Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup LocalBuilder flow and added docs #96

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat: cleanup LocalBuilder flow and added docs #96

merged 1 commit into from
Jun 27, 2024

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Jun 26, 2024 •
edited
Loading

  • Added FallbackPayloadBuilder as a field of LocalBuilder
  • LocalBuilder is the only public facing API for anything builder-specific now
  • Getting ready for the integration into the upstream builder api impl
  • Added helpful docs & comments

@merklefruit merklefruit self-assigned this Jun 26, 2024
namn-grg
namn-grg approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@namn-grg namn-grg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merklefruit merklefruit merged commit ff44875 into feat/sidecar/builder-api Jun 27, 2024
@merklefruit merklefruit deleted the 06-26-feat_cleanup_and_added_docs branch June 27, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namn-grg namn-grg namn-grg approved these changes

@thedevbirb thedevbirb thedevbirb approved these changes

@mempirate mempirate Awaiting requested review from mempirate

Assignees

@merklefruit merklefruit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merklefruit @thedevbirb @namn-grg