Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: constraints api integration #3

Merged
merged 80 commits into from
Oct 18, 2024
Merged

feat: constraints api integration #3

merged 80 commits into from
Oct 18, 2024

Conversation

namn-grg
Copy link

No description provided.

@namn-grg namn-grg changed the base branch from lore/feat/constrainst-api to main September 12, 2024 20:19
@namn-grg namn-grg marked this pull request as draft September 13, 2024 06:54
thedevbirb
thedevbirb reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just two little nits I've noticed so far

crates/api/src/builder/api.rs Outdated Show resolved Hide resolved
crates/api/src/builder/api.rs Show resolved Hide resolved
thedevbirb
thedevbirb reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Made a first review. Will do another round more detailed at a later time

crates/api/src/builder/api.rs Outdated Show resolved Hide resolved
crates/api/src/router.rs Outdated Show resolved Hide resolved
crates/common/src/proofs.rs Outdated Show resolved Hide resolved
crates/common/src/proofs.rs Outdated Show resolved Hide resolved
crates/common/src/proofs.rs Outdated Show resolved Hide resolved
crates/utils/src/signing.rs Outdated Show resolved Hide resolved
@namn-grg namn-grg marked this pull request as ready for review September 20, 2024 10:12
namn-grg and others added 26 commits October 3, 2024 14:38
@namn-grg
fix: devnet fixes by lore
6caf0ae
@thedevbirb
fix: in proposer duties table primary key should not be the public key
7d5cce3
@merklefruit
fix: get header with proof resp type
e248ae1
@thedevbirb
Merge pull request #10 from chainbound/nico/fix/header-resp
33ac5a5 
fix: get header with proof resp type
@namn-grg
fix: use cb domain for sig verification
48ccc45
@namn-grg
Merge pull request #9 from chainbound/naman/fix/domain
3ff59a8 
fix: verify signature with domain
@merklefruit
fix: deserialize signed builder bid with proofs
0171648
@merklefruit
feat: add deserialization test
5968ce5
@merklefruit
Merge pull request #11 from chainbound/nico/fix/signed-bid
d5ccc41 
fix: deserialize signed builder bid with proofs
@thedevbirb
fix: sleep duration before refreshing validators to 200ms
972c7c3
@thedevbirb
fix: in proposer duties table primary key should not be the public ke…
3c12f79 
…y v2
@merklefruit
chore: add log for invalid constraints signature
54aa9fe
@merklefruit
Merge branch 'naman/devnet' of github.com:chainbound/helix into naman…
5fe9714 
…/devnet
@merklefruit
fix(devnet): compute tx hash via tx envelope
a698899
@merklefruit
fix: calc proofs
295fe36
@merklefruit
chore: addressed review
4b2386b
@merklefruit
chore: addressed review
bd69fc5
@merklefruit
feat: signed message actions (with runtime check)
3e7167b
@merklefruit
feat: add validator pubkey validation in constraint submission
61df5f4
@merklefruit
fix: disallow validator key if there are delegations
5cf2aa2
@merklefruit
chore: typo
afdcb8b
@merklefruit
chore: addressed review
40d50e5
@thedevbirb
Merge pull request #8 from chainbound/naman/devnet
5898d70 
working devnet
@merklefruit
feat(api): save delegations/revocations in batch
6479b95
@merklefruit
chore: addressed review
0112adc
@thedevbirb
Merge pull request #14 from chainbound/nico/chore/delegations-vec
95d8c04 
feat(api): save delegations/revocations in batch
@merklefruit merklefruit changed the base branch from main to bolt October 18, 2024 08:25
@merklefruit merklefruit merged commit 1b9ba22 into bolt Oct 18, 2024
1 check passed
@merklefruit merklefruit deleted the naman/feat/constraints-api-new branch October 18, 2024 08:26
@merklefruit merklefruit restored the naman/feat/constraints-api-new branch October 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedevbirb thedevbirb thedevbirb left review comments

@merklefruit merklefruit merklefruit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@namn-grg @merklefruit @thedevbirb