feat: add dune support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
namn-grg
commented
Jun 24, 2024
•
namn-grg
commented
- Add feature to upload the data to dune periodically
namn-grg
commented
Jun 25, 2024
consumer/dune.go
Outdated
Comment on lines
12
to
21
| const ( | ||
| duneAPIKey = "" | ||
| namespace = "" | ||
| tableName = "validators_location" | ||
| apiURL = "http://localhost:8080/validators" | ||
| createEndpoint = "https://api.dune.com/api/v1/table/create" | ||
| clearEndpoint = "https://api.dune.com/api/v1/table/%s/%s/clear" | ||
| insertEndpoint = "https://api.dune.com/api/v1/table/%s/%s/insert" | ||
| contentType = "application/x-ndjson" | ||
| ) |
There was a problem hiding this comment.
I can add these as CLI options too but I felt its not really needed
mempirate
reviewed
Jun 25, 2024
consumer/dune.go
Outdated
| const ( | ||
| duneAPIKey = "" | ||
| namespace = "" | ||
| tableName = "validators_location" |
mempirate
reviewed
Jun 25, 2024
consumer/dune.go
Outdated
| t := time.Unix(unixTimestamp, 0) | ||
|
|
||
| // Format the time.Time object to a readable date string | ||
| return t.Format("2006-01-02") |
There was a problem hiding this comment.
Can we make it more granular here? I.e. show HH:MM:SS
chore: improve validator tracker
added 6 commits
June 26, 2024 11:35
This reverts commit 5c25a18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.