Exclude protobuf 3.8.0rc1 from dependencies #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
added
cat:install
|
Jenkins, test this please. |
|
Successfully created a job for commit 5496640: |
1 similar comment
|
Successfully created a job for commit 5496640: |
|
Jenkins CI test (for commit 5496640, target branch master) succeeded! |
hvy
added
the
st:test-and-merge
|
Hm, convolution_2d tests are failing on pfnCI but are they even related to this PR? Edit: Seemed like they were not but were rather cased by the latest CuPy. Temporarily going back to an older version of CuPy got rid of the failures. Will merge this PR once everything looks green. |
|
LGTM! |
hvy
added a commit
to hvy/chainer
that referenced
this pull request
May 8, 2019
Exclude protobuf 3.8.0rc1 from dependencies
hvy
removed
the
st:test-and-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CI is broken in master.
It turned out that cause is protobuf==3.8.0rc1 being used in CIs.
In some CIs we install Chainer with
python setup.py install, which causes pre-release dependencies to be installed (pypa/setuptools/issues/855).This PR is a temporary workaround.
We should probably always use pip for installing chainer.