Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI job #220

Merged
merged 4 commits into from
Aug 13, 2019
Merged

Add Windows CI job #220

merged 4 commits into from
Aug 13, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Aug 7, 2019

  • "onnxchainer.win.chainer-pre" job added
  • On pytest 5, got Windows fatal exception" on onnx.checker.ValidationError`. I didn't detect the error but fixed using pytest<5

@disktnk disktnk added this to the 1.5.1 milestone Aug 7, 2019
@disktnk
Copy link
Member Author

disktnk commented Aug 7, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 163b52d:

@codecov-io
Copy link

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files          24       24           
  Lines        1529     1529           
=======================================
  Hits         1376     1376           
  Misses        153      153
Impacted Files Coverage Δ
onnx_chainer/functions/array.py 90.51% <100%> (ø) ⬆️
onnx_chainer/functions/math.py 85.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2242a0...163b52d. Read the comment docs.

@shinh
Copy link
Member

shinh commented Aug 13, 2019

LGTM! (sorry for the large latency)

@disktnk disktnk merged commit 644980f into chainer:master Aug 13, 2019
@disktnk disktnk deleted the fix/win branch August 13, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants