Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to ignore not variable inputs #221

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Aug 7, 2019

- [ ] consider model params to reduce memory consumption

resolve #216 #214

@disktnk disktnk added this to the 1.5.1 milestone Aug 7, 2019
@disktnk disktnk changed the title [WIP] Fix to ignore not variable inputs Fix to ignore not variable inputs Aug 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #221 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   89.99%   90.05%   +0.05%     
==========================================
  Files          24       24              
  Lines        1529     1528       -1     
==========================================
  Hits         1376     1376              
+ Misses        153      152       -1
Impacted Files Coverage Δ
onnx_chainer/export.py 93.18% <ø> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2242a0...43008aa. Read the comment docs.

Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retain hook does not support ndarray
3 participants