Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move implicit input manager to Context #226

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Aug 17, 2019

To support overwriting input name manually. fixes #225

  • add unit tests

@disktnk disktnk added this to the 1.5.1 milestone Aug 17, 2019
@disktnk disktnk changed the title Move implicit input manager to Context [WIP] Move implicit input manager to Context Aug 17, 2019
@codecov-io
Copy link

codecov-io commented Aug 17, 2019

Codecov Report

Merging #226 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   90.22%   90.45%   +0.23%     
==========================================
  Files          24       24              
  Lines        1555     1551       -4     
==========================================
  Hits         1403     1403              
+ Misses        152      148       -4
Impacted Files Coverage Δ
onnx_chainer/export.py 93.18% <100%> (ø) ⬆️
onnx_chainer/context.py 98.43% <100%> (+0.02%) ⬆️
onnx_chainer/functions/normalization.py 95% <100%> (+4.52%) ⬆️
onnx_chainer/graph.py 95.6% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eebbf2...1d3feb9. Read the comment docs.

@disktnk disktnk changed the title [WIP] Move implicit input manager to Context Move implicit input manager to Context Aug 18, 2019
Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@disktnk disktnk merged commit 930aa2e into chainer:master Aug 19, 2019
@disktnk disktnk deleted the fix/bn-unused-values branch August 19, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set unused variable on initializer, using fixed-batchnormalization
3 participants