Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PowConstVar and PowVarVar #234

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Conversation

shinh
Copy link
Member

@shinh shinh commented Sep 26, 2019

No description provided.

@shinh shinh requested a review from disktnk September 26, 2019 09:50
@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #234 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   90.92%   90.98%   +0.05%     
==========================================
  Files          24       24              
  Lines        1598     1608      +10     
==========================================
+ Hits         1453     1463      +10     
  Misses        145      145
Impacted Files Coverage Δ
onnx_chainer/mapping.py 90% <ø> (ø) ⬆️
onnx_chainer/functions/__init__.py 100% <100%> (ø) ⬆️
onnx_chainer/functions/math.py 89.42% <100%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ad021...aea7d5e. Read the comment docs.

@disktnk
Copy link
Member

disktnk commented Sep 26, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit aea7d5e:

Copy link
Member

@disktnk disktnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@disktnk disktnk merged commit 33abf6b into chainer:master Sep 26, 2019
@disktnk disktnk added this to the 1.5.1 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants