Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow UserWarning handling on testing #242

Merged
merged 5 commits into from
Oct 3, 2019
Merged

Follow UserWarning handling on testing #242

merged 5 commits into from
Oct 3, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Oct 3, 2019

  • same with Chainer's pytest configuration
    • error on unexpected warning
    • ignore experimental warning
  • handle UserWarning on testing
    • drop warning check manually

@disktnk disktnk added this to the 1.5.1 milestone Oct 3, 2019
shinh
shinh approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you'll fix the test failure

@codecov-io
Copy link

codecov-io commented Oct 3, 2019 •
edited
Loading

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files          23       23           
  Lines        1615     1615           
=======================================
  Hits         1464     1464           
  Misses        151      151
Impacted Files Coverage Δ
onnx_chainer/export.py 93.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3088ae7...d49cd1d. Read the comment docs.

@disktnk disktnk merged commit 643097e into chainer:master Oct 3, 2019
@disktnk disktnk deleted the fix/user-warning branch October 3, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinh shinh shinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@disktnk @codecov-io @shinh