Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melange considers packages which provide an absolute symlink as providing the target #1775

Open
murraybd opened this issue Feb 4, 2025 · 2 comments

Comments

@murraybd
Copy link
Contributor

murraybd commented Feb 4, 2025

@smoser made a change to melange, #1662, which he believes introduced a regression that melange will follow an absolute symlink and consider the package as providing the target even though the package is not actually providing or vendoring the shared object.

When discussing the fix @jonjohnsonjr mentioned that we should do global melange scan to confirm the sensibility of the changes.

This issue manifests itself quite regularly in package build logs of packages in the following way:

solving "keyutils-libs" constraint:   keyutils-libs-1.6.3-r5.apk disqualified because keyutils-dev-1.6.3-r5.apk already provides so:libkeyutils.so.1
  keyutils-libs-1.6.3-r0.apk disqualified because keyutils-dev-1.6.3-r5.apk already provides so:libkeyutils.so.1
  keyutils-libs-1.6.3-r1.apk disqualified because keyutils-dev-1.6.3-r5.apk already provides so:libkeyutils.so.1
  keyutils-libs-1.6.3-r2.apk disqualified because keyutils-dev-1.6.3-r5.apk already provides so:libkeyutils.so.1
  keyutils-libs-1.6.3-r3.apk disqualified because keyutils-dev-1.6.3-r5.apk already provides so:libkeyutils.so.1
  keyutils-libs-1.6.3-r4.apk disqualified because keyutils-dev-1.6.3-r5.apk already provides so:libkeyutils.so.1
  keyutils-libs-1.6.3-r5.apk disqualified because keyutils-dev-1.6.3-r5.apk already provides so:libkeyutils.so.1
@sil2100
Copy link
Member

sil2100 commented Feb 5, 2025

I've seen a lot of these during my latest glibc Wolfi test-rebuild. I also saw it during my first test-rebuild 2 weeks ago, but much less frequent. Right now most of the builds failed due to this, while previously only a small set.
Is this caused by a race-condition? Since I get a feeling that sometimes I see it more and sometimes less?

Is there a workaround for this?

@imjasonh
Copy link
Member

imjasonh commented Feb 5, 2025

Related possible fix #1739

jonjohnsonjr added a commit to jonjohnsonjr/os that referenced this issue Feb 5, 2025
There is an absolute symlink that is tripping up melange's SCA when run
with bubblewrap.

chainguard-dev/melange#1775

Signed-off-by: Jon Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants