-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist and restore trace headers in workqueue #554
Comments
I realized this wasn't properly threaded when opening: chainguard-dev#554 spelling out how to save/restore trace headers. Signed-off-by: Matt Moore <[email protected]>
…555) I realized this wasn't properly threaded when opening: #554 spelling out how to save/restore trace headers. Signed-off-by: Matt Moore <[email protected]>
For pubsub, this was the PR #374 . Newer PubSub client sets a message attribute named For work queue, since we control the request dispatching, we don't need to do stuffs in a metrics handler, but just set the |
Does that do what we expect transitively? It feels like that would have a relatively shallow effect? 🤔 |
I left a TODO here tagging @tcnghia because he worked this magic for Pub/Sub:
terraform-infra-common/pkg/workqueue/gcs/gcs.go
Lines 70 to 72 in c79371c
I'm guessing it's not a ton of work, but we need to extract the relevant headers and encode them above.
Then restore them here:
terraform-infra-common/pkg/workqueue/gcs/gcs.go
Lines 250 to 253 in c79371c
I also need to fix the dispatcher to properly use this
Context()
method, which is an oversight on my part, which I'll correct now.The text was updated successfully, but these errors were encountered: