lentille - log invalid gitlab date

change-metrics · Jan 28, 2025 · 10d7262 · 10d7262
1 parent 8ffa58d
commit 10d7262
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/Lentille/GitLab/Adapter.hs b/src/Lentille/GitLab/Adapter.hs
@@ -9,7 +9,7 @@ module Lentille.GitLab.Adapter where
 import Data.Morpheus.Client
 import Data.Text qualified as TE
 import Data.Time.Clock
-import Data.Time.Format (defaultTimeLocale, formatTime, parseTimeOrError)
+import Data.Time.Format (defaultTimeLocale, formatTime)
 import Google.Protobuf.Timestamp qualified as T
 import Lentille (ghostIdent, nobody, toIdent)
 import Monocle.Config qualified as Config
@@ -71,11 +71,9 @@ timeToTimestamp formatStringE = T.fromUTCTime . timeToUTCTime formatStringE
 timeToUTCTime :: Maybe String -> Time -> UTCTime
 timeToUTCTime formatStringE t =
   let Time tt = t
-   in parseTimeOrError
-        False
-        defaultTimeLocale
-        (fromMaybe "%FT%XZ" formatStringE)
-        $ from tt
+   in case parseDateValue (from tt) of
+        Nothing -> error $ "Unknown time format: " <> from tt
+        Just utc -> utc
 
 cleanMaybeMNodes :: Maybe [Maybe a] -> [a]
 cleanMaybeMNodes nodes = catMaybes $ fromMaybe [] nodes

diff --git a/src/Lentille/GitLab/MergeRequests.hs b/src/Lentille/GitLab/MergeRequests.hs
@@ -10,7 +10,7 @@ module Lentille.GitLab.MergeRequests where
 import Data.Morpheus.Client
 import Data.Text qualified as TE
 import Data.Time.Clock
-import Data.Time.Format (defaultTimeLocale, formatTime, parseTimeOrError)
+import Data.Time.Format (defaultTimeLocale, formatTime)
 import Data.Vector qualified as V
 import Google.Protobuf.Timestamp qualified as T
 import Lentille