Skip to content

Commit

Permalink
v0.3.8 (#262)
Browse files Browse the repository at this point in the history
v0.3.8
  • Loading branch information
aooen authored Mar 4, 2021
2 parents 41bf872 + d550ca1 commit 8a0dc12
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@channel.io/design-system",
"version": "0.3.7",
"version": "0.3.8",
"description": "Design System by Channel",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion src/components/List/ListItem/ListItem.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('ListItem', () => {
const { getByTestId } = renderComponent({ href: 'https://naver.com' })
const rendered = getByTestId(LIST_ITEM_COMPONENT_NAME)
expect(rendered).toHaveAttribute('href', 'https://naver.com')
expect(rendered).toHaveAttribute('rel', 'noopener noreferer')
expect(rendered).toHaveAttribute('rel', 'noopener noreferrer')
expect(rendered).toHaveAttribute('target', '_blank')
})
})
2 changes: 1 addition & 1 deletion src/components/List/ListItem/ListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function ListItemComponent({
draggable={false}
href={href}
target="_blank"
rel="noopener noreferer"
rel="noopener noreferrer"
onClick={handleClick}
active={false}
data-active={active}
Expand Down
4 changes: 2 additions & 2 deletions src/components/TabAction/TabAction.styled.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* Internal dependencies */
import { UIComponentProps } from '../../types/ComponentProps'
import { styled, css } from '../../foundation'
import { Icon } from '../Icon'
import { StyledWrapperProps } from './TabAction.types'
Expand All @@ -9,8 +10,7 @@ export const Wrapper = styled.div<StyledWrapperProps>`
height: ${({ height }) => height}px;
`

interface BackgroundProps {
href?: string
interface BackgroundProps extends UIComponentProps {
padding?: number
borderRadius?: number
disabled?: boolean
Expand Down
2 changes: 2 additions & 0 deletions src/components/TabAction/TabAction.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ function TabActionComponent({
<Background
as={isNil(href) ? 'div' : 'a'}
href={href}
target="_blank"
rel="noopener noreferrer"
onClick={handleClick}
{...backgroundSizeProp}
>
Expand Down
6 changes: 2 additions & 4 deletions src/components/Tabs/index.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import Tabs from './Tabs'
/* eslint-disable import/no-duplicates */
import { TabsSize } from './Tabs.types'
import type TabsProps from './Tabs.types'
import type { TabsSize } from './Tabs.types'
/* eslint-enable import/no-duplicates */

export type {
TabsProps,
TabsSize,
}

export {
Tabs,
TabsSize,
}

0 comments on commit 8a0dc12

Please sign in to comment.