Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button component should be disabled when it is loading state #2299

Closed
yangwooseong opened this issue Jun 20, 2024 · 2 comments
Closed

Button component should be disabled when it is loading state #2299

yangwooseong opened this issue Jun 20, 2024 · 2 comments
Assignees
@jintak0401
Labels
enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers

Comments

@yangwooseong
Copy link
Collaborator

yangwooseong commented Jun 20, 2024 •
edited
Loading

Description

버튼이 로딩 상태일 때 컴포넌트 내부적으로 disabled된 상태면 좋겠습니다 (suggested by @igy95 )

Reasons for suggestion

현재 disabled 처리를 해주고 있지 않아서, 어플리케이션에서 버튼이 로딩 상태일 때 disabled인 곳과 아닌 곳이 혼재되어 있습니다.

Proposed solution

  1. V2의 AlphaButton 까지 수정되면 좋겠습니다.
  2. (optional) 만약 어플리케이션에서 disabled와 loading 에 같은 값을 주고 있는 경우가 많다면, disabled 속성을 제거하는 codemod를 만들어봐도 좋을 것 같습니다.

References

스레드(internal)
@yangwooseong yangwooseong added the status:need triage Issue or PR that need triage attention label Jun 20, 2024
@github-project-automation github-project-automation bot moved this to 📌 Backlog in Bezier React Jun 20, 2024
@channeltalk ChannelTalk
Copy link

channeltalk bot commented Jun 20, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/6673c5b5b8543958b9a5

@yangwooseong yangwooseong added enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers and removed status:need triage Issue or PR that need triage attention labels Jun 20, 2024
@yangwooseong
Copy link
Collaborator Author

논의 스레드 (internal)

@sungik-choi sungik-choi mentioned this issue Nov 29, 2024
Merged
6 tasks
jintak0401 added a commit that referenced this issue Dec 5, 2024
@jintak0401
modify default value of Button's disabled props to follow loading pro…
c8e5578 
…ps (#2510)

<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [ ] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [ ] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [ ] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

#2299 

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

## Summary

<!-- Please brief explanation of the changes made -->

- Button 의 disabled 의 기본값을 false 에서 loading 을 따라가도록 수정합니다. 

## Details

<!-- Please elaborate description of the changes -->

- loading: true, disabled: undefined -> disabled: true
- loading: true, disabled: false -> disabled: false


https://github.com/user-attachments/assets/c05e5848-91c5-46bc-bf0e-c7cfdab2002b

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jintak0401 jintak0401

Labels
enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers
Projects
No open projects
Bezier React
Status: 📌 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yangwooseong @jintak0401