Remove alpha dimension token & Add alpha radius token #2540
+76
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d02be38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 143 143
Lines 2985 2985
Branches 923 919 -4
=======================================
Hits 2457 2457
+ Misses 523 497 -26
- Partials 5 31 +26 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
yangwooseong
reviewed
Dec 5, 2024
| '@channel.io/bezier-tokens': minor | ||
| --- | ||
|
|
||
| The alpha version dimension token is removed. The alpha version radius token is added. |
There was a problem hiding this comment.
- alpha 토큰 변경사항은 항상 patch bump 로 생각했는데 그게 아닌가요?
yangwooseong
reviewed
Dec 5, 2024
| "value": "20px", | ||
| "type": "dimension" | ||
| }, | ||
| "32": { |
There was a problem hiding this comment.
워크플로우쪽 사이드 프리뷰에서 dimension-30 을 쓰고 있는 부분이 있는데 아마 32의 오타 인것 같아서 확인해보면 좋을것 같아요. 전화 프리뷰의 radius 는 30px이고 아닌 경우는 32px로 되어있네요
yangwooseong
approved these changes
Dec 5, 2024
yangwooseong
pushed a commit
that referenced
this pull request
Dec 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Minor Changes - Update icons ([#2545](#2545)) by @ch-builder Modified - arrow-left-up-small.svg - arrow-up.svg - chevron-right-double.svg - naver-talktalk.svg Added - chevron-down-bold.svg - chevron-left-bold.svg - chevron-right-bold.svg - chevron-up-bold.svg ## @channel.io/[email protected] ### Patch Changes - If disabled is not passed from Button's props, disabled follows loading ([#2510](#2510)) by @jintak0401 - Updated dependencies - @channel.io/[email protected] ## @channel.io/[email protected] ### Patch Changes - The alpha version dimension token is removed. The alpha version radius token is added. ([#2540](#2540)) by @sungik-choi ## @channel.io/[email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Summary
Remove alpha dimension token & Add alpha radius token
Details
Breaking change? (Yes/No)
No (alpha version)
References