Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeaderArea grid template column 값 조정 #264

Merged
merged 1 commit into from
Mar 9, 2021
Merged

HeaderArea grid template column 값 조정 #264

merged 1 commit into from
Mar 9, 2021

Conversation

jwoo0122
Copy link
Contributor

@jwoo0122 jwoo0122 commented Mar 8, 2021 •
edited
Loading

Description

Header column 값 조정 (멋대로 늘어나지 않도록)

Changes Detail

  • 1fr 을 minmax(0, 1fr) 로 수정

Tests

  • Jest 테스트 코드 작성 완료
  • Storybook 작성 완료

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • Chrome - Blink
  • Edge - Blink
  • Firefox - Gecko (Option)

macOS

  • Chrome - Blink
  • Edge - Blink
  • Safari - WebKit
  • Firefox - Gecko (Option)

(Option) Issues

(연관된 PR이나 Task / 특정 시점까지 머지하면 안됨 / 번역 추가 필요 / ...)

  • 이슈 없음.

@jwoo0122 jwoo0122 merged commit 14d473c into channel-io:exp Mar 9, 2021
@jwoo0122 jwoo0122 deleted the bugfix/header-grid-columns branch March 9, 2021 12:17
@jwoo0122 jwoo0122 mentioned this pull request Mar 9, 2021
Merged
4 tasks
@quino0627 quino0627 mentioned this pull request Mar 9, 2021
Merged
9 tasks
@quino0627 quino0627 linked an issue Mar 11, 2021 that may be closed by this pull request
레이아웃 및 네비게이션 Refactor 및 버그 수정 #224
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quino0627 quino0627 quino0627 approved these changes

Assignees

@jwoo0122 jwoo0122

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

레이아웃 및 네비게이션 Refactor 및 버그 수정
2 participants
@jwoo0122 @quino0627