Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

네비게이션 버그 수정 및 디자인 대응 #286

Merged
merged 5 commits into from
Mar 28, 2021

Conversation

quino0627
Copy link
Contributor

@quino0627 quino0627 commented Mar 26, 2021

Description

  • 네비게이션 숨기는 버튼이 데스크에서 작아지는 문제를 수정했습니다
  • 네비게이션을 show 여부를 밖에서 조정할 경우에 네비게이션 내부 state를 변화시키지 못하는 문제를 수정했습니다
    ㄴ 예전에 생겼던 내부 state를 삭제하고 reducer를 보도록 변경했습니다
  • GNB 접근 시에 Navigation 이 너무 자주 hover되는것 같아 throttle 값을 조금 늘렸습니다(100->350)
  • 디자인 변경사항을 수정했습니다

image
image

Changes Detail

@quino0627 quino0627 self-assigned this Mar 26, 2021
src/components/Header/Header.tsx Outdated Show resolved Hide resolved
@jwoo0122 jwoo0122 mentioned this pull request Mar 27, 2021
6 tasks
@quino0627 quino0627 marked this pull request as draft March 28, 2021 10:46
@quino0627 quino0627 marked this pull request as ready for review March 28, 2021 10:47
Comment on lines -16 to -19
width: 20px;
height: 20px;
padding: 6px;
color: #979797;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이콘이 작아 보이던 것은
box-sizing 옵션이 디자인 시스템과 데스크가 달라서 발생하던 문제

@quino0627 quino0627 linked an issue Mar 28, 2021 that may be closed by this pull request
@jwoo0122 jwoo0122 merged commit 8342eab into channel-io:exp Mar 28, 2021
@jwoo0122 jwoo0122 deleted the bugfix/small-icon-header branch March 28, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

네비게이션 가리기가 찌부됨
2 participants