-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
네비게이션 버그 수정 및 디자인 대응 #286
Merged
Merged
네비게이션 버그 수정 및 디자인 대응 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo0122
suggested changes
Mar 27, 2021
jwoo0122
approved these changes
Mar 27, 2021
Navigation Local State가 남아있어서 발생하던 문제
jwoo0122
reviewed
Mar 28, 2021
quino0627
commented
Mar 28, 2021
Comment on lines
-16
to
-19
width: 20px; | ||
height: 20px; | ||
padding: 6px; | ||
color: #979797; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아이콘이 작아 보이던 것은
box-sizing 옵션이 디자인 시스템과 데스크가 달라서 발생하던 문제
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ㄴ 예전에 생겼던 내부 state를 삭제하고 reducer를 보도록 변경했습니다
Changes Detail