Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootElement 계산의 Server side 상황 대응 #302

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

jwoo0122
Copy link
Contributor

@jwoo0122 jwoo0122 commented Apr 5, 2021

Description

rootElement 가 document 를 참조할 때, 서버 환경에서 에러 발생하는 문제 수정

Tests

  • Jest 테스트 코드 작성 완료
  • Storybook 작성 완료

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • Chrome - Blink
  • Edge - Blink
  • Firefox - Gecko (Option)

macOS

  • Chrome - Blink
  • Edge - Blink
  • Safari - WebKit
  • Firefox - Gecko (Option)

(Option) Issues

(연관된 PR이나 Task / 특정 시점까지 머지하면 안됨 / 번역 추가 필요 / ...)

  • 이슈 없음.

@jwoo0122 jwoo0122 merged commit a1020d3 into channel-io:exp Apr 5, 2021
@jwoo0122 jwoo0122 deleted the bugfix/ssr-windows-rootelement branch April 5, 2021 10:32
@jwoo0122 jwoo0122 mentioned this pull request Apr 5, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants