Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the build config #825

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Jun 10, 2022

Summary

  • React v18 마이그레이션 #771 에서 React v18이 적용되면서, IE11에 대한 지원이 종료되었습니다. 타겟 브라우저에서 IE11을 제외하고, es6 타겟으로 타입 선언을 생성하도록 설정을 변경합니다
  • 라이브러리 사용처에서 소스 파일을 쉽게 확인할 수 있도록 declarationMap 설정을 추가합니다.

Details

지원 브라우저 리스트에서 IE11이 제거됩니다.

and_chr 101
chrome 100
chrome 99
edge 100
edge 99
firefox 99
- ie 11 
ios_saf 15.4
ios_saf 15.2-15.3
ios_saf 15.0-15.1
ios_saf 14.5-14.8
safari 15.4
safari 14.1
safari 13.1
samsung 16.0
samsung 7.2-7.4

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • Chrome - Blink
  • Edge - Blink
  • Firefox - Gecko (Option)

macOS

  • Chrome - Blink
  • Edge - Blink
  • Safari - WebKit
  • Firefox - Gecko (Option)

References

@sungik-choi sungik-choi added the enhancement Issues or PR related to making existing features better label Jun 10, 2022
@sungik-choi sungik-choi added this to the next-v2.0.0 milestone Jun 10, 2022
@sungik-choi sungik-choi self-assigned this Jun 10, 2022
@sungik-choi sungik-choi changed the title Enhance build config Enhance the build config Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #825 (ec4aac5) into next-v1 (4129ad6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           next-v1     #825   +/-   ##
========================================
  Coverage    67.81%   67.81%           
========================================
  Files          204      204           
  Lines         2862     2862           
  Branches       784      784           
========================================
  Hits          1941     1941           
  Misses         803      803           
  Partials       118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe9155...ec4aac5. Read the comment docs.

"> 1% in KR",
"> 1% in JP",
"> 1% in US"
"> 1% in US",
"not ie <= 11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

데스크도 이거 추가해야 할 듯

"declarationDir": "build",
"noEmit": true,
"module": "esnext",
"target": "es5",
"target": "es6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

브라우저 목록에 있는 브라우저들 모두 es6 지원하나요?

Copy link
Contributor Author

@sungik-choi sungik-choi Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I use 참고해보면 모두 지원하고 있어요.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세상이 좋아졌어 ~

@sungik-choi sungik-choi merged commit ff0711b into channel-io:next-v1 Jun 22, 2022
@sungik-choi sungik-choi deleted the enhance/package-json branch June 22, 2022 11:23
@ch-builder
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next-v1.144 🎉

The release is available on:

Your semantic-release bot 📦🚀

quino0627 added a commit that referenced this pull request Jun 23, 2022
@sungik-choi sungik-choi mentioned this pull request Jun 30, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues or PR related to making existing features better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants