Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prototype code for validating fragement file #1095

Closed
wants to merge 14 commits into from

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Nov 14, 2024

Reason for Change

Changes

  • add cli command
$ cellxgene-schema validate-fragment -h                                                                                                    
Usage: cellxgene-schema validate-fragment [OPTIONS] H5AD_FILE FRAGMENT_FILE

  Check that an ATAC SEQ fragment follows the cellxgene data integration schema. If
  validation fails this command will return an exit status of 1 otherwise 0. When
  the '--generate-index' tag is present, the command will generate a tabix
  compatible version of the fragment and tabix index. The generated fragment will
  have the file suffix .bgz and the index will have the file suffix .bgz.tbi.

Options:
  -i, --generate-index  Generate index for fragment
  -h, --help            Show this message and exit.
  • add requirements to run dask in local distributed mode
  • add validation steps for ATAC-SEQ fragment file
  • add tabix index generation steps.

Testing

  • TESTS NEEDED
pip install git+https://github.com/chanzuckerberg/single-cell-curation/@tsmith/10x-ATAC#subdirectory=cellxgene_schema_cli

Remaining Work

chanzuckerberg/single-cell#724

Copy link
Contributor

github-actions bot commented Dec 7, 2024

This PR has not seen any activity in the past 2 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Dec 7, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 17 days, 3 days since being marked as stale. Please re-open if you still need this to be addressed.

Copy link
Contributor

github-actions bot commented Jan 5, 2025

This PR has not seen any activity in the past 2 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Jan 5, 2025
@Bento007 Bento007 removed the Stale label Jan 7, 2025
Copy link
Contributor

This PR has not seen any activity in the past 2 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Jan 22, 2025
@github-actions github-actions bot removed the Stale label Jan 23, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 84.02778% with 23 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (f31d095) to head (e6be307).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   90.52%   90.05%   -0.47%     
==========================================
  Files          18       19       +1     
  Lines        2068     2212     +144     
==========================================
+ Hits         1872     1992     +120     
- Misses        196      220      +24     
Components Coverage Δ
cellxgene_schema_cli 91.06% <84.02%> (-0.79%) ⬇️
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.80% <ø> (ø)
schema_bump_dry_run_ontologies 99.53% <ø> (ø)

Copy link
Contributor

github-actions bot commented Feb 8, 2025

This PR has not seen any activity in the past 2 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Feb 8, 2025
Copy link
Contributor

This PR was closed because it has been inactive for 17 days, 3 days since being marked as stale. Please re-open if you still need this to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant