-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add genetic ancestry fields for schema 5.3 #1132
Conversation
@@ -582,3 +582,15 @@ components: | |||
- "cell culture" | |||
- "organoid" | |||
- "tissue" | |||
genetic_ancestry_African: | |||
type: genetic_ancestry_value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i initially tried doing something like:
type: float
rule: genetic_ancestry_African >= 0 and genetic_ancestry_African <= 1 or genetic_ancestry_African == float('nan')
but i couldn't quite figure out how to get the NaN check to work correctly with the query syntax. so i just created a new genetic_ancestry_value
type
d89ed66
to
e30070e
Compare
add genetic ancestry fields
e4d5a58
to
36901ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but its missing validation for "All observations with the same donor_id MUST contain the same value." for each genetic_ancestry_*
b65f2d1
to
477f592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, non-blocking. Implementation looks good!
Reason for Change
https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-curation/1114
Changes
adds all the genetic ancestry fields as well as related validation. i also updated
example_valid.h5ad
with:Testing
Notes for Reviewer