feat: exclude generic visium (EFO:0010961) from allowed assay_ontology_term

[ejmolinelli]

Reason for Change

• cellxgene-schema CLI must update validation for obs['assay_ontology_term_id'] #1189

Changes

• exclude self when checking if assay is a descendant of EFO:0010961
• remove use of EFO:0010961 from tests where it is expected to yield a successful validation
• add explicit test for EFO:0010961 and append a custom error message for this error.

Testing

• Most of the test updates were to replace EFO:0010961 with a lower, valid term e.g. EFO:0022857 (v1) or EFO:0022858 (v2) or EFO:0022859 (6.5mm)

pip install git+https://github.com/chanzuckerberg/single-cell-curation/@main#subdirectory=cellxgene_schema_cli

Notes for Reviewer

• Lattice confirmed that the existing error messages related to valid spatial assays is sufficient.
• it would be nice to extend the schema validator to include visium checks - perhaps this is a maintenance task.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5189d95). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage        ?   89.84%           
=======================================
  Files           ?       18           
  Lines           ?     2098           
  Branches        ?        0           
=======================================
  Hits            ?     1885           
  Misses          ?      213           
  Partials        ?        0           

Components	Coverage Δ
cellxgene_schema_cli	90.84% <100.00%> (?)
migration_assistant	91.26% <ø> (?)
schema_bump_dry_run_genes	79.80% <ø> (?)
schema_bump_dry_run_ontologies	99.53% <ø> (?)

[joyceyan]

i'm guessing pre-commit was added because you discovered it was a dev dependency?