Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for mus musculus descendant organisms #1248

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Feb 4, 2025

Reason for Change

https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-curation/1243

Changes

  • updates schema definition to add support for mus musculus descendants
  • upon further inspection it appears as if the print output for ONTOLOGY_PARSER.get_term_descendants("NCBITaxon:10090", include_self=True) is simply term_descendants ['NCBITaxon:10090']

Testing

added unit tests to ensure mouse descendant terms are accepted

Notes for Reviewer

@joyceyan joyceyan force-pushed the joyce/mouse-descendants branch from 8c952d4 to a085ed8 Compare February 6, 2025 22:32
@joyceyan joyceyan requested a review from ejmolinelli February 6, 2025 22:45
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (011bbad) to head (a085ed8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
- Coverage   89.92%   89.90%   -0.02%     
==========================================
  Files          19       19              
  Lines        2193     2200       +7     
==========================================
+ Hits         1972     1978       +6     
- Misses        221      222       +1     
Components Coverage Δ
cellxgene_schema_cli 90.86% <100.00%> (-0.03%) ⬇️
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.80% <ø> (ø)
schema_bump_dry_run_ontologies 99.53% <ø> (ø)

Copy link
Contributor

@ejmolinelli ejmolinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joyceyan joyceyan merged commit 0aaf700 into main Feb 7, 2025
12 of 14 checks passed
@joyceyan joyceyan deleted the joyce/mouse-descendants branch February 7, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants