-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for all secondary species #1250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good outside of the failing test. feel free to ping me when it's resolved and i'll approve it!
…olved feature_name
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
- Coverage 89.95% 89.64% -0.31%
==========================================
Files 19 19
Lines 2200 2222 +22
==========================================
+ Hits 1979 1992 +13
- Misses 221 230 +9
|
9662b58
to
db7c46a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run make check
in the root directory to fix the linter, but otherwise LGTM!
Reason for Change
By 'secondary' species, we mean species for which support mostly involves the inclusion of a gene reference annotation file and the direct enumeration as a permitted species. There is no further ontological integration necessary
Changes
make gene-processing
to fetch the reference, extract the gene information and create the gene*.csv.gz
artifact.obs.organism_ontology_term_id
to permit the new species.Testing
Notes for Reviewer