Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for all secondary species #1250

Merged
merged 24 commits into from
Feb 7, 2025

Conversation

ejmolinelli
Copy link
Contributor

Reason for Change

By 'secondary' species, we mean species for which support mostly involves the inclusion of a gene reference annotation file and the direct enumeration as a permitted species. There is no further ontological integration necessary

Changes

  • Each species generally involved the same process
  1. registration with gene_info.yml to link the species name to the gene reference file
  2. running make gene-processing to fetch the reference, extract the gene information and create the gene *.csv.gz artifact.
  3. adding the species to the list of enumerated species in the gencode.py file
  4. updating the schema_definition obs.organism_ontology_term_id to permit the new species.

Testing

  • no additional testing is necessary

Notes for Reviewer

Copy link
Contributor

@joyceyan joyceyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good outside of the failing test. feel free to ping me when it's resolved and i'll approve it!

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (0aaf700) to head (b4a9191).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
- Coverage   89.95%   89.64%   -0.31%     
==========================================
  Files          19       19              
  Lines        2200     2222      +22     
==========================================
+ Hits         1979     1992      +13     
- Misses        221      230       +9     
Components Coverage Δ
cellxgene_schema_cli 90.48% <70.96%> (-0.44%) ⬇️
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.74% <100.00%> (-0.07%) ⬇️
schema_bump_dry_run_ontologies 99.53% <ø> (ø)

@ejmolinelli ejmolinelli force-pushed the ejmolinelli/secondary-species branch from 9662b58 to db7c46a Compare February 7, 2025 02:33
Copy link
Contributor

@joyceyan joyceyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run make check in the root directory to fix the linter, but otherwise LGTM!

@ejmolinelli ejmolinelli merged commit 241cefd into main Feb 7, 2025
11 of 14 checks passed
@ejmolinelli ejmolinelli deleted the ejmolinelli/secondary-species branch February 7, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants