fix: determine species from gene file, not from gene prefix #1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
it seems like the issue with
RR
prefixed genes with fruit fly was a bit of a patchwork solution to a slightly bigger problem, which is that inferring organism species based on gene id prefix is not entirely correct. see this issue with a gorilla gene prefixed withENSGGOG
gets incorrectly mapped to homo sapiensChanges
gencode.get_organism_from_feature_id
to go through each individual gene checker, rather than rely on gene prefixTesting
test_gencode
to assert that we're mapping the organism from feature id correctlyNotes for Reviewer