Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check type of uns["spatial"][library_id] is dict #886

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented May 7, 2024

Reason for Change

Changes

  • add acheck that uns["spatial"][library_id] is dict

Testing

  • add new unit test

Notes for Reviewer

Copy link
Collaborator

@brian-mott brian-mott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now only dict is allowed for uns['spatial'][library_id] values.
Thanks!

@Bento007 Bento007 merged commit 86ec382 into main May 8, 2024
6 checks passed
@Bento007 Bento007 deleted the tsmith/bug-2 branch May 8, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants