Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update migration_template for linting and generate_script.py to add GENCODE_MAPPER #914

Merged
merged 3 commits into from
May 16, 2024
Merged

fix: update migration_template for linting and generate_script.py to add GENCODE_MAPPER #914

merged 3 commits into from
May 16, 2024

Conversation

nayib-jose-gloria
Copy link
Contributor

Reason for Change

Changes

  • add GENCODE_MAPPER, newly added and tested for in migrate.py for 5.0.0, as default empty map defined in migration_template even if no GENCODE changes occurred (to fulfill tests written for it)
  • keep trailing newline when generating migration script, to satisfy linting in auto-generated migrate script

Bento007
Bento007 reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@Bento007 Bento007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may need to add # noqa to some lines to silence the formatters.

@nayib-jose-gloria
Copy link
Contributor Author

you may need to add # noqa to some lines to silence the formatters.

do you know which? or know how to check which

@Bento007
Copy link
Contributor

Bento007 commented May 16, 2024 •
edited
Loading

you may need to add # noqa to some lines to silence the formatters.

do you know which? or know how to check which

I was thinking in the jinja template if we were having a hard time getting migration.py to conform.

@nayib-jose-gloria nayib-jose-gloria merged commit a2b8101 into main May 16, 2024
6 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/fix-migrate-script-generator branch May 16, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bento007 Bento007 Bento007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayib-jose-gloria @Bento007