Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cxg conversion script updates for uns #6909

Closed
wants to merge 23 commits into from

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Apr 10, 2024

Reason for Change

Changes

  • Added logic to extract uns dictionary from AnnData and store object under uns directory in the cxg
  • Cast in_tissue column values to boolean to make it categorical, and fix the issue of it appearing as "continuous" in explorer
  • Added unit test coverage

Testing steps

https://cellxgene.dev.single-cell.czi.technology/e/super-cool-spatial.cxg/?spatial=true

Local testing:
run def make_cxg() in a notebook or from the command line against a valid AnnData/h5ad dataset.
run converted cxg in explorer, verify spatial mode

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.65%. Comparing base (a0954b5) to head (791ec30).

Files Patch % Lines
backend/common/utils/cxg_generation_utils.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6909   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         182      183    +1     
  Lines       15354    15390   +36     
=======================================
+ Hits        14072    14106   +34     
- Misses       1282     1284    +2     
Flag Coverage Δ
unittests 91.65% <94.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster requested a review from danieljhegeman April 11, 2024 15:25
@kaloster kaloster removed the request for review from danieljhegeman April 15, 2024 17:32
@kaloster
Copy link
Contributor Author

kaloster commented Apr 15, 2024

@kaloster kaloster closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant