thuang-radio-useState #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## upload-dataset-feature #816 +/- ##
=========================================================
Coverage ? 94.87%
=========================================================
Files ? 66
Lines ? 3612
Branches ? 0
=========================================================
Hits ? 3427
Misses ? 185
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thanks for the quick review, @seve ! Merging 🤩! |
tihuan
added a commit
that referenced
this pull request
Jan 21, 2021
* switch select for radio * switch to context * small fix + popover start * fix dataset button styles * thuang-radio-useState (#816) * Seve/706 fe delete cancel upload (#832) * css fixes/tweaks to make room for cancel button * assign gutters as left padding * Place cancel button * create delete dataset query * use mutation instead of query * button successfully cancels * handle errors from server * cancel check util * switch back to cancel_pending * early exit if cancelled * grab datasetid from response * add alert to delete dataset * remove errors and logging * allow nullish with error handling * brackets * null -> undefined * thuang-705-upload-datasets-part-3 (#835) * thuang-705-upload-datasets-part-3 * handling useDeleteDataset() * add back error handling * only poll dataset metadata when valid * update checkIfFailed() to check conversion failed first * use Blueprint buttons for Download Modal * add tryUntil() test helper * update DeleteDataset Cancel Button style Co-authored-by: Seve Badajoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
Readability:
Changes