Skip to content

Commit

Permalink
Merge pull request #561 from chanzuckerberg/main
Browse files Browse the repository at this point in the history
chore: deploy staging <- main
  • Loading branch information
Daniel Hegeman authored Feb 7, 2023
2 parents 261776d + 65b3890 commit 1146dbb
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 17 deletions.
23 changes: 23 additions & 0 deletions .github/ISSUE_TEMPLATE/tech-issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Tech Issue
about: Engineering-specific technical work that is not product-specific. Engineering team "owns" these issues.
title: ""
labels: tech
assignees: ""
---

## Motivation

Why is this work important to engineers?

## Definition of Done

What should the end result look like? What will have been changed?

## Tasks

Detail the specific tasks that can be used to accomplish the desired changes.
If detailed steps cannot be provided at this time, please file a [Tech Proposal](https://docs.google.com/document/d/1o2vuvl-kXwRJN1nBoPzJS_MAQgDGYnjmPZWa4qRDi-I/edit#heading=h.7dvzhm7gqc3v) instead.

- [ ]
- [ ]
2 changes: 1 addition & 1 deletion LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2017-2022 Chan Zuckerberg Initiative
Copyright (c) 2017-2023 Chan Zuckerberg Initiative

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
Expand Down
24 changes: 12 additions & 12 deletions client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion server/common/compute/estimate_distribution.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def estimate_approximate_distribution(X) -> XApproximateDistribution:
if Xdata.size > CHUNKSIZE:
min_val = max_val = Xdata[0]
with concurrent.futures.ThreadPoolExecutor() as tp:
for (_min, _max) in tp.map(min_max, [Xdata[i : i + CHUNKSIZE] for i in range(0, Xdata.size, CHUNKSIZE)]):
for _min, _max in tp.map(min_max, [Xdata[i : i + CHUNKSIZE] for i in range(0, Xdata.size, CHUNKSIZE)]):
min_val = min(_min, min_val)
max_val = max(_max, max_val)

Expand Down
1 change: 0 additions & 1 deletion server/common/config/app_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ class AppConfig(object):
"""

def __init__(self, config_file_path: str = None):

# the default configuration (see default_config.py)
self.default_config: dict = get_default_config()
# TODO @madison -- if we always read from the default config (hard coded path) can we set those values as
Expand Down
2 changes: 1 addition & 1 deletion server/common/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def summarizeQueryHash(raw_query):
HTTPStatus.OK,
{"Content-Type": "application/octet-stream"},
)
except (ValueError) as e:
except ValueError as e:
return abort(HTTPStatus.NOT_FOUND, description=str(e))
except (UnsupportedSummaryMethod, FilterError) as e:
return abort(HTTPStatus.BAD_REQUEST, description=str(e))
Expand Down
1 change: 0 additions & 1 deletion server/dataset/cxg_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def pack_selector_from_mask(boolarray):


def pack_selector_from_indices(selector):

if len(selector) == 0:
return None

Expand Down

0 comments on commit 1146dbb

Please sign in to comment.