fix: Fix menubar overflow by removing undo redo, some letters, and um…

…ap icon (#466) * fix overflow by removing undo redo, some letters, and umap icon * undo removal of undo redo Co-authored-by: atarashansky <[email protected]>
chanzuckerberg · Sep 27, 2022 · 20251bb · 20251bb
1 parent fafc539
commit 20251bb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/client/__tests__/e2e/data.ts b/client/__tests__/e2e/data.ts
@@ -98,7 +98,7 @@ export const datasets = {
       },
       lasso: {
         "coordinates-as-percent": { x1: 0.25, y1: 0.05, x2: 0.75, y2: 0.55 },
-        count: "357",
+        count: "332",
       },
     },
     scatter: {

diff --git a/client/src/components/embedding/index.tsx b/client/src/components/embedding/index.tsx
@@ -5,7 +5,6 @@ import {
   Button,
   ButtonGroup,
   H4,
-  MaybeElement,
   Popover,
   Position,
   Radio,
@@ -18,9 +17,6 @@ import { getDiscreteCellEmbeddingRowIndex } from "../../util/stateManager/viewSt
 import { track } from "../../analytics";
 import { EVENTS } from "../../analytics/events";
 
-import heatmapIcon from "./heatmap.svg";
-import { SvgIcon } from "../svgIcon";
-
 // eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
 type EmbeddingState = any;
 
@@ -78,16 +74,13 @@ class Embedding extends React.PureComponent<{}, EmbeddingState> {
               <Button
                 type="button"
                 data-testid="layout-choice"
-                icon={
-                  (<SvgIcon src={heatmapIcon} />) as unknown as MaybeElement
-                }
                 id="embedding"
                 style={{
                   cursor: "pointer",
                 }}
                 onClick={this.handleLayoutChoiceClick}
               >
-                {layoutChoice?.current}: {crossfilter.countSelected()} out of{" "}
+                {layoutChoice?.current}: {crossfilter.countSelected()} of{" "}
                 {crossfilter.size()} cells
               </Button>
             </Tooltip>

diff --git a/client/src/components/menubar/cellSetButtons.tsx b/client/src/components/menubar/cellSetButtons.tsx
@@ -42,8 +42,6 @@ class CellSetButton extends React.PureComponent {
           }}
           data-testid={`cellset-button-${eitherCellSetOneOrTwo}`}
         >
-          {eitherCellSetOneOrTwo}
-          {": "}
           <span data-testid={`cellset-count-${eitherCellSetOneOrTwo}`}>
             {cellsSelected}
           </span>