chore: back merge hotfix (#157)

* Updated help and documentation links. (#145) (#146) * fix: Full fix QuickGene (#151) Co-authored-by: Mim Hastie <[email protected]>
chanzuckerberg · Oct 15, 2021 · 2922f4a · 2922f4a
2 parents 03bd9af + 7eb97f7
commit 2922f4a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 21 deletions.
diff --git a/client/src/components/floatingButton/floatingButton.tsx b/client/src/components/floatingButton/floatingButton.tsx
@@ -17,19 +17,19 @@ function FloatingButton(): JSX.Element {
       content={
         <Menu>
           <MenuItem
-            href="https://docs.cellxgene.cziscience.com/"
+            href="https://github.com/chanzuckerberg/cellxgene-documentation/blob/main/README.md"
             rel="noopener"
             target="_blank"
             text="Documentation"
           />
           <MenuItem
-            href="https://docs.cellxgene.cziscience.com/explore-data/explorer-tutorials"
+            href="https://github.com/chanzuckerberg/cellxgene-documentation/blob/main/explore-data/explorer-tutorials.md"
             rel="noopener"
             target="_blank"
             text="Tutorials"
           />
           <MenuItem
-            href="https://docs.cellxgene.cziscience.com/roadmap"
+            href="https://github.com/chanzuckerberg/cellxgene-documentation/blob/main/roadmap.md"
             rel="noopener"
             target="_blank"
             text="Our Roadmap"

diff --git a/client/src/components/geneExpression/quickGene.tsx b/client/src/components/geneExpression/quickGene.tsx
@@ -116,25 +116,22 @@ function QuickGene() {
       threshold: -10000, // don't return bad results
     });
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
-  const removeGene = (gene: any) => () => {
-    dispatch({ type: "clear user defined gene", data: gene });
-  };
+  const QuickGenes = useMemo((): JSX.Element => {
+    const removeGene = (gene: any) => () => {
+      dispatch({ type: "clear user defined gene", data: gene });
+    };
 
-  const QuickGenes = useMemo(
-    () =>
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
-      userDefinedGenes.map((gene: any) => (
-        <Gene
-          key={`quick=${gene}`}
-          // @ts-expect-error ts-migrate(2322) FIXME: Type '{ key: string; gene: any; removeGene: (gene:... Remove this comment to see the full error message
-          gene={gene}
-          removeGene={removeGene}
-          quickGene
-        />
-      )),
-    [userDefinedGenes]
-  );
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
+    return userDefinedGenes.map((gene: any) => (
+      <Gene
+        key={`quick=${gene}`}
+        // @ts-expect-error ts-migrate(2322) FIXME: Type '{ key: string; gene: any; removeGene: (gene:... Remove this comment to see the full error message
+        gene={gene}
+        removeGene={removeGene}
+        quickGene
+      />
+    ));
+  }, [userDefinedGenes, dispatch]);
 
   return (
     <div style={{ width: "100%", marginBottom: "16px" }}>