fix: Continuous legend properly disappears after coloring by continuo…

…us metadata and subsequently coloring by anything else (#513) * branch init * ensure colorbar is removed if asyncProps contains colorMode=color by categorical * remove log Co-authored-by: atarashansky <[email protected]>
chanzuckerberg · Oct 21, 2022 · fa59fa5 · fa59fa5
1 parent a75caf1
commit fa59fa5
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/client/src/components/continuousLegend/index.tsx b/client/src/components/continuousLegend/index.tsx
@@ -265,7 +265,11 @@ class ContinuousLegend extends React.Component<Props> {
               }
               this.cachedAsyncProps = asyncProps;
               // if asyncProps is null (no colorAccessor), remove legend
-              if (!asyncProps)
+              // or if colorMode is categorical, remove legend
+              if (
+                !asyncProps ||
+                asyncProps.colorMode === "color by categorical metadata"
+              )
                 d3.select("#continuous_legend").selectAll("*").remove();
               return null;
             }}