chore: Upgrade to BlueprintJS 5 - SCE-4 #1068
Conversation
kaloster
force-pushed
the
kaloster/update-blueprintjs
branch
2 times, most recently
from
bd756eb to
a272473
Compare
There was a problem hiding this comment.
Looks really good so far thanks so much! Just some minor questions 😄
Last nit is that I saw some test snapshots still have bp3 and that there's maybe two or three code comments that still refer to bp3 that we probably need to update to bp5?
Thank you so much again for this two major version upgrade!
...instance-layout-gra-26a66-taset-and-collection-from-breadcrumbs-appears-2-chromium-linux.txt
Outdated
Show resolved
Hide resolved
| "@blueprintjs/core": "^5.11.0", | ||
| "@blueprintjs/icons": "^5.11.0", | ||
| "@blueprintjs/select": "^5.2.2", |
There was a problem hiding this comment.
thank you SO much for doing this upgrade!! 🏆 🚀 👏 !!
kaloster
force-pushed
the
kaloster/update-blueprintjs
branch
from
b6749a2 to
5a54140
Compare
kaloster
force-pushed
the
kaloster/update-blueprintjs
branch
from
16adf4e to
f3c3f8b
Compare
kaloster
force-pushed
the
kaloster/update-blueprintjs
branch
2 times, most recently
from
52c52c7 to
47b99dd
Compare
| @@ -1,5 +1,5 @@ | |||
| import React from "react"; | |||
| import { InputGroup, MenuItem, Keys } from "@blueprintjs/core"; | |||
There was a problem hiding this comment.
blueprintjs Keys is deprecated, using named keys instead
|
@kaloster commented: Hey Timmy! good question 🙂 I've updated all snapshots and removed all the ones that still had bp3 references after the update - could it be that those are just leftovers from previous runs, like snapshots that just remained over the changes to tests in the past year? most of the ones removed are from 6-8 months ago. In any case tests seem to pass after removing those snapshots |
kaloster
force-pushed
the
kaloster/update-blueprintjs
branch
from
f18f864 to
c96bbaf
Compare
kaloster
changed the title
JIRA Issue SCE-4
Changes:
rdev -> HERE