Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to BlueprintJS 5 - SCE-4 #1068

Merged
merged 5 commits into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .infra/rdev/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ stack:
services:
explorer:
image:
tag: sha-517004d0
tag: sha-c96bbaf8
replicaCount: 1
env:
# env vars common to all deployment stages
Expand Down
19 changes: 0 additions & 19 deletions client/__tests__/e2e/__snapshots__/e2e.test.ts.snap

This file was deleted.

2 changes: 1 addition & 1 deletion client/__tests__/e2e/cell-guide.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Smoke test suite that will be run in GHA
* Tests included in this file are expected to be relatively stable and test core features
*
* (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp3 elements which route clicks to non-target elements
* (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp5 elements which route clicks to non-target elements
* https://playwright.dev/docs/input#forcing-the-click
*/

Expand Down

This file was deleted.

This file was deleted.

37 changes: 1 addition & 36 deletions client/__tests__/e2e/cellxgeneActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -862,43 +862,8 @@ export async function selectLayout(
if (graphTsetId === sidePanel) {
layoutChoiceTestId = `${LAYOUT_CHOICE_TEST_ID}-side`;
}

await page.getByTestId(layoutChoiceTestId).click({ force: true });

/**
* (thuang): For blueprint radio buttons, we need to tab first to go to the
* currently selected option before we can use the arrow keys to navigate
*/
await page.keyboard.press("Tab");

const layoutChoices = await await page
.getByTestId(RegExp(`^${LAYOUT_CHOICE_TEST_ID}-label-`))
.allInnerTexts();

const currentlySelectedLayout = await page
.locator("label")
.filter({ has: page.getByRole("radio", { checked: true }) })
.innerText();

const currentIndex = layoutChoices.indexOf(currentlySelectedLayout);
const targetIndex = layoutChoices.findIndex((choice) =>
choice.includes(layoutChoice)
);

const relativePosition = targetIndex - currentIndex;

if (relativePosition > 0) {
// press down arrow N times
for (let i = 0; i < relativePosition; i += 1) {
await page.keyboard.press("ArrowDown");
}
} else {
// press up arrow N times
for (let i = 0; i < Math.abs(relativePosition); i += 1) {
await page.keyboard.press("ArrowUp");
}
}

await page.getByTestId(`layout-choice-label-${layoutChoice}`).click();
await page.getByTestId(layoutChoiceTestId).click({ force: true });

await page.waitForTimeout(WAIT_FOR_SWITCH_LAYOUT_MS);
Expand Down
2 changes: 1 addition & 1 deletion client/__tests__/e2e/e2e.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Smoke test suite that will be run in GHA
* Tests included in this file are expected to be relatively stable and test core features
*
* (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp3 elements which route clicks to non-target elements
* (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp5 elements which route clicks to non-target elements
* https://playwright.dev/docs/input#forcing-the-click
*/

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading