Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up e2eAnnotations.test.ts #213

Closed
atolopko-czi opened this issue Jan 20, 2022 · 0 comments
Closed

Clean up e2eAnnotations.test.ts #213

atolopko-czi opened this issue Jan 20, 2022 · 0 comments
Assignees
@atarashansky

Comments

@atolopko-czi
Copy link
Contributor

There are tests in client/__tests__/e2e/e2eAnnotations.test.ts that are related to user annotations, which are no longer supported in hosted Explorer. These can be removed.

There are also tests, listed below, that continue to have value and these are not currently being run by any GHA job. These should be kept, and probably moved into more appropriately-named test files. And they should be run by the GHA push_tests.yml smoke-tests job.

  • "geneSET crud operations and interactions"
  • "GENE crud operations and interactions"
  • "stacked bar graph renders"
    • Need to look into this one, but can't remember why this was implemented as a annnotations test
  • "truncate midpoint whitespace"
    • Easily added as a new category to test dataset
  • "truncate single character"
    • Likewise

Originally posted by @seve in #180 (comment)
@atolopko-czi atolopko-czi mentioned this issue Jan 20, 2022
Merged
1 task
@atarashansky atarashansky self-assigned this Jun 11, 2022
This was referenced Jun 11, 2022
Closed
Merged
atarashansky added a commit that referenced this issue Jul 27, 2022
@atarashansky
chore: clean up e2eAnnotations.test.ts #213 (#281)
85b215b 
* removed irrelevant tests from e2e annotations and added it to push_tests.yml

* merged tests, added back truncation tests, and removed annotation tests from makefiles

* removing

Co-authored-by: Alexander Tarashansky <[email protected]>
atarashansky added a commit that referenced this issue Jul 27, 2022
@atarashansky
Revert "chore: clean up e2eAnnotations.test.ts #213 (#281)"
0b7dc7e 
This reverts commit 85b215b.
@czi-github-helper czi-github-helper bot mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atarashansky atarashansky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atarashansky @atolopko-czi