fix: Fixes missing breadcrumbs introduced in unified navbar update. #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atarashansky
changed the title
Codecov Report
@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 74.99% 74.99%
=======================================
Files 99 99
Lines 7815 7815
=======================================
Hits 5861 5861
Misses 1954 1954
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seve
approved these changes
Sep 27, 2022
atarashansky
added a commit
that referenced
this pull request
Sep 28, 2022
* chore: Update clipping smoke test to ensure categorical data appears properly when clipping (#456) * ensure categorical data appears properly when clipping * update snapshot Co-authored-by: atarashansky <[email protected]> * feat: add hotkeys for undo redo and remove buttons (#467) * add hotkeys for undo redo and remove buttons * add hotkey component * remove extraneous from menubar * update to command on macs * update puppeteer hotkey to mac version Co-authored-by: atarashansky <[email protected]> * fix: Fix menubar overflow by removing undo redo, some letters, and umap icon (#466) * fix overflow by removing undo redo, some letters, and umap icon * undo removal of undo redo Co-authored-by: atarashansky <[email protected]> * fix: Fixes missing breadcrumbs introduced in unified navbar update. (#465) * fix breadcrumbs * add smoke tests * remove breadcrumbs smoke tests temporarily * update stub * comment out breadcrumbs smoke test for now Co-authored-by: atarashansky <[email protected]> * fix: fixing a bug that occurs when there are more than 1000 categories (#462) * fixing a bug that occurs when there are more than 1000 categories * add truncation testing dataset * add test for truncation * update * update test * update ordering of fixture * update fixture to string counts instead of ints Co-authored-by: atarashansky <[email protected]> * chore(deps): bump minimist and jimp in /client (#468) Bumps [minimist](https://github.com/substack/minimist) and [jimp](https://github.com/oliver-moran/jimp). These dependencies needed to be updated together. Updates `minimist` from 0.0.8 to 1.2.6 - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/commits) Updates `jimp` from 0.2.28 to 0.16.1 - [Release notes](https://github.com/oliver-moran/jimp/releases) - [Changelog](https://github.com/oliver-moran/jimp/blob/master/CHANGELOG.md) - [Commits](jimp-dev/jimp@0.2.28...v0.16.1) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect - dependency-name: jimp dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: atarashansky <[email protected]> * remove platform spec (#469) Co-authored-by: atarashansky <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463
Due to some miscommunication, the change to the dataset breadcrumbs feature (it moved to the bottom of the screen) was not properly tested prior to merging the unified navbar update. This issue was not caught by smoke tests as there were no smoke tests for the breadcrumbs feature.
I attempted to add the tests to this PR but encountered difficulty getting the
dataset-metadataendpoint to properly mock in puppeteer. To unblock staging deployment today, we will add the smoke tests in for bread crumbs in a separate ticket.