Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename - Right Sidebar #1112

Merged
merged 6 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .infra/rdev/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ stack:
services:
explorer:
image:
tag: sha-c15484e5
tag: sha-1e81e0f8
replicaCount: 1
env:
# env vars common to all deployment stages
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Button, Dialog, Classes, Colors, Tooltip } from "@blueprintjs/core";
type State = any;

// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
class AnnoDialog extends React.PureComponent<{}, State> {
export class AnnoDialog extends React.PureComponent<{}, State> {
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
constructor(props: {}) {
super(props);
Expand Down Expand Up @@ -113,5 +113,3 @@ class AnnoDialog extends React.PureComponent<{}, State> {
);
}
}

export default AnnoDialog;
4 changes: 2 additions & 2 deletions client/src/components/App/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import DiffexNotice from "../DiffexNotice/DiffexNotice";
import BottomBanner from "../BottomBanner/BottomBanner";
import Container from "../framework/container";
import Layout from "../framework/layout";
import LayoutSkeleton from "../framework/layoutSkeleton";
import { LayoutSkeleton } from "../framework/LayoutSkeleton/LayoutSkeleton";
import LeftSideBar from "../LeftSidebar/LeftSidebar";
import RightSideBar from "../rightSidebar";
import RightSideBar from "../RightSideBar/RightSideBar";
import Legend from "../Legend/Legend";
import MenuBar from "../MenuBar/MenuBar";
import NavBar from "../NavBar/NavBar";
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/DiffexNotice/DiffexNotice.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* Core dependencies */
import React, { useState, useEffect } from "react";
import { noop } from "lodash";
import { Link } from "../geneExpression/infoPanel/common/style";
import { Link } from "components/RightSideBar/components/GeneExpression/components/InfoPanel/components/InfoPanelContainer/style";
import { StyledSnackbar, StyledAlert } from "./style";

interface Props {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import fuzzysort from "fuzzysort";
type State = any;

// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
export default class LabelInput extends React.PureComponent<{}, State> {
export class LabelInput extends React.PureComponent<{}, State> {
/*
Input widget for text labels, which acts like an InputGroup, but will also
accept a suggestion list (of labels), with sublime-like suggest search.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react";

import GeneExpression from "../geneExpression";
import InfoPanel from "../geneExpression/infoPanel";
import GeneExpression from "./components/GeneExpression/GeneExpression";
import InfoPanel from "./components/GeneExpression/components/InfoPanel/InfoPanel";
import { RightSidebarWrapper } from "./style";

function RightSidebar() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import { connect } from "react-redux";
import { Button, H4, H5, Icon } from "@blueprintjs/core";
import { IconNames } from "@blueprintjs/icons";

import GeneSet from "./geneSet";
import QuickGene from "./quickGene";
import CreateGenesetDialogue from "./menus/createGenesetDialogue";
import { track } from "../../analytics";
import { EVENTS } from "../../analytics/events";
import * as globals from "../../globals";
import { Dataframe, DataframeValue } from "../../util/dataframe";
import { track } from "analytics";
import { EVENTS } from "analytics/events";
import { Dataframe, DataframeValue } from "util/dataframe";

import { GeneSet } from "./components/GeneSet/GeneSet";
import { QuickGene } from "./components/QuickGene/QuickGene";
import { CreateGenesetDialogue } from "./components/CreateGenesetDialogue/CreateGenesetDialogue";

import * as globals from "~/globals";
import { MARKER_GENE_SUFFIX_IDENTIFIER } from "./constants";

// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import uniq from "lodash.uniq";
import React from "react";
import { connect } from "react-redux";
import { Button, Dialog, Classes, Colors, Tooltip } from "@blueprintjs/core";
import LabelInput from "../../labelInput";
import actions from "../../../actions";
import { track } from "../../../analytics";
import { EVENTS } from "../../../analytics/events";
import { LabelInput } from "components/LabelInput/LabelInput";
import actions from "actions";
import { track } from "analytics";
import { EVENTS } from "analytics/events";

// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
type State = any;
Expand All @@ -25,7 +25,7 @@ type State = any;
genesetsUI: (state as any).genesetsUI,
}))
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
class CreateGenesetDialogue extends React.PureComponent<{}, State> {
export class CreateGenesetDialogue extends React.PureComponent<{}, State> {
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
constructor(props: {}) {
super(props);
Expand Down Expand Up @@ -239,5 +239,3 @@ class CreateGenesetDialogue extends React.PureComponent<{}, State> {
);
}
}

export default CreateGenesetDialogue;
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ import { EVENTS } from "analytics/events";
import { ActiveTab } from "common/types/entities";
import { InfoButton, InfoButtonWrapper } from "common/style";
import Truncate from "common/components/Truncate/Truncate";

import { State, Props, mapStateToProps, mapDispatchToProps } from "./types";
import { MINI_HISTOGRAM_WIDTH } from "../constants";
import { MINI_HISTOGRAM_WIDTH } from "../../constants";

class Gene extends React.Component<Props, State> {
constructor(props: Props) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { AppDispatch, RootState } from "../../../reducers";
import { DataframeValue } from "../../../util/dataframe";
import { AppDispatch, RootState } from "reducers";
import { DataframeValue } from "util/dataframe";

export interface State {
geneIsExpanded: boolean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ import BrushableHistogram from "common/components/BrushableHistogram/BrushableHi
import { track } from "analytics";
import { EVENTS } from "analytics/events";
import Truncate from "common/components/Truncate/Truncate";
import Gene from "./gene";
import Gene from "../Gene/Gene";
import * as globals from "~/globals";
import GenesetMenus from "./menus/genesetMenus";
import EditGenesetNameDialogue from "./menus/editGenesetNameDialogue";
import { GenesetMenus } from "./components/GeneSetMenus/GenesetMenus";
import { EditGenesetNameDialogue } from "./components/EditGenesetNameDialogue/EditGenesetNameDialogue";

import { diffexpPopNamePrefix1, diffexpPopNamePrefix2 } from "~/globals";

// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
type State = any;

// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
class GeneSet extends React.Component<{}, State> {
export class GeneSet extends React.Component<{}, State> {
isGeneExpressionLoadComplete = false;

// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
Expand Down Expand Up @@ -175,5 +175,3 @@ class GeneSet extends React.Component<{}, State> {
);
}
}

export default GeneSet;
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react";
import { connect } from "react-redux";
import AnnoDialog from "../../annoDialog";
import LabelInput from "../../labelInput";
import { AnnoDialog } from "components/AnnoDialog/AnnoDialog";
import { LabelInput } from "components/LabelInput/LabelInput";

// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
type State = any;
Expand All @@ -20,7 +20,7 @@ type State = any;
genesets: (state as any).genesets.genesets,
}))
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
class RenameGeneset extends React.PureComponent<{}, State> {
export class EditGenesetNameDialogue extends React.PureComponent<{}, State> {
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
constructor(props: {}) {
super(props);
Expand Down Expand Up @@ -150,5 +150,3 @@ class RenameGeneset extends React.PureComponent<{}, State> {
);
}
}

export default RenameGeneset;
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import {
PopoverInteractionKind,
Tooltip,
} from "@blueprintjs/core";
import * as globals from "../../../globals";
import actions from "../../../actions";
import AddGeneToGenesetDialogue from "./addGeneToGenesetDialogue";
import { track } from "../../../analytics";
import { EVENTS } from "../../../analytics/events";
import { MARKER_GENE_SUFFIX_IDENTIFIER } from "../constants";
import actions from "actions";
import { track } from "analytics";
import { EVENTS } from "analytics/events";
import * as globals from "~/globals";
import { AddGeneToGenesetDialogue } from "./components/AddGeneToGenesetDialogue/AddGeneToGenesetDialogue";
import { MARKER_GENE_SUFFIX_IDENTIFIER } from "../../../../constants";

// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
type State = any;
Expand All @@ -31,7 +31,7 @@ type State = any;
colorLoading: (state as any).controls.colorLoading,
}))
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
class GenesetMenus extends React.PureComponent<{}, State> {
export class GenesetMenus extends React.PureComponent<{}, State> {
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
constructor(props: {}) {
super(props);
Expand Down Expand Up @@ -179,5 +179,3 @@ class GenesetMenus extends React.PureComponent<{}, State> {
);
}
}

export default GenesetMenus;
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import React from "react";
import { connect } from "react-redux";
import AnnoDialog from "../../annoDialog";
import LabelInput from "../../labelInput";
import parseBulkGeneString from "../../../util/parseBulkGeneString";
import actions from "../../../actions";
import { track } from "../../../analytics";
import { EVENTS } from "../../../analytics/events";
import { AnnoDialog } from "components/AnnoDialog/AnnoDialog";
import { LabelInput } from "components/LabelInput/LabelInput";
import parseBulkGeneString from "util/parseBulkGeneString";
import actions from "actions";
import { track } from "analytics";
import { EVENTS } from "analytics/events";

// eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
type State = any;
Expand All @@ -16,7 +16,7 @@ type State = any;
genesetsUI: (state as any).genesetsUI,
}))
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
class AddGeneToGenesetDialogue extends React.PureComponent<{}, State> {
export class AddGeneToGenesetDialogue extends React.PureComponent<{}, State> {
// eslint-disable-next-line @typescript-eslint/ban-types --- FIXME: disabled temporarily on migrate to TS.
constructor(props: {}) {
super(props);
Expand Down Expand Up @@ -102,5 +102,3 @@ class AddGeneToGenesetDialogue extends React.PureComponent<{}, State> {
);
}
}

export default AddGeneToGenesetDialogue;
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ import { connect } from "react-redux";
import { AnchorButton, ButtonGroup } from "@blueprintjs/core";
import { Tabs, Tab } from "@czi-sds/components";

import { ActiveTab } from "common/types/entities";
import {
CollapseToggle,
InfoPanelContent,
InfoPanelHeader,
InfoPanelWrapper,
} from "./style";
import CellTypeInfo from "./infoPanelCellType";
import GeneInfo from "./infoPanelGene";
import DatasetInfo from "./infoPanelDataset";
import CellTypeInfo from "./components/CellTypeInfo/CellTypeInfo";
import GeneInfo from "./components/GeneInfo/GeneInfo";
import DatasetInfo from "./components/DatasetInfo/DatasetInfo";
import { Props, mapStateToProps } from "./types";
import useConnect from "./connect";
import { ActiveTab } from "../../../common/types/entities";

function InfoPanel(props: Props) {
const { activeTab, dispatch, infoPanelMinimized, infoPanelHidden } = props;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React, { useMemo } from "react";
import { connect } from "react-redux";
import { Props, mapStateToProps } from "./types";
import InfoPanelContainer from "../common/infoPanelContainer";
import { CELLGUIDE_URL } from "../common/constants";
import { InfoPanelContainer } from "../InfoPanelContainer/InfoPanelContainer";
import { CELLGUIDE_URL } from "../InfoPanelContainer/constants";

function CellTypeInfo(props: Props) {
const { cellInfo, cellTypes } = props;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { RootState } from "../../../../reducers";
import { RootState } from "reducers";

export interface Props {
cellInfo: RootState["controls"]["cellInfo"];
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useMemo } from "react";
import { selectableCategoryNames } from "../../../../util/stateManager/controlsHelpers";
import { selectableCategoryNames } from "util/stateManager/controlsHelpers";
import { Props } from "./types";

export function useConnect({
Expand All @@ -25,7 +25,7 @@ export function useConnect({
}
});

singleContinuousValues.forEach((value, catName) => {
singleContinuousValues.forEach((value: any, catName: any) => {
singleValues.set(catName, value);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import {
Consortium,
Link,
PublisherMetadata,
} from "../../../../common/types/entities";
import { Category } from "../../../../common/types/schema";
import * as globals from "../../../../globals";
import { RootState } from "../../../../reducers";
} from "common/types/entities";
import { Category } from "common/types/schema";
import { RootState } from "reducers";
import * as globals from "~/globals";

const COLLECTION_LINK_ORDER_BY = [
"DOI",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { RootState } from "../../../../reducers";
import { RootState } from "reducers";

export interface Props {
datasetMetadata: RootState["datasetMetadata"]["datasetMetadata"];
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import React from "react";
import { connect } from "react-redux";
import { Props, mapStateToProps } from "./types";

import InfoPanelContainer from "../common/infoPanelContainer";

import { EMPTY_ARRAY } from "../../../../common/constants";
import { EMPTY_ARRAY } from "common/constants";
import { Props, mapStateToProps } from "./types";
import { InfoPanelContainer } from "../InfoPanelContainer/InfoPanelContainer";

function GeneInfo(props: Props) {
const { geneInfo, geneList } = props;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { RootState } from "../../../../reducers";
import { RootState } from "reducers";

export interface Props {
geneInfo: RootState["controls"]["geneInfo"];
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import React from "react";
import { kebabCase } from "lodash";
import { InfoContainer, InfoWrapper } from "../style";
import {
ErrorInfo,
LoadingInfo,
NoneSelected,
ShowInfo,
} from "../infoPanelParts";
import { ExtendedInfoProps } from "../types";
import InfoSearch from "../infoSearch";
import { InfoContainer, InfoWrapper } from "./style";

function InfoPanelContainer(props: ExtendedInfoProps) {
import { ErrorInfo } from "./components/ErrorInfo/ErrorInfo";
import { NoneSelected } from "./components/NoneSelected/NoneSelected";
import { LoadingInfo } from "./components/LoadingInfo/LoadingInfo";
import { ShowInfo } from "./components/ShowInfo/ShowInfo";
import { ExtendedInfoProps } from "./types";
import InfoSearch from "./components/InfoSearch/InfoSearch";

export function InfoPanelContainer(props: ExtendedInfoProps) {
const {
id,
name,
Expand Down Expand Up @@ -73,5 +72,3 @@ function InfoPanelContainer(props: ExtendedInfoProps) {
</InfoWrapper>
);
}

export default InfoPanelContainer;
Loading
Loading