Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix seamless caching #191

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Conversation

atolopko-czi
Copy link
Contributor

https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/chanzuckerberg/single-cell-explorer/166

Reviewers

Functional:
@Bento007

Readability:
@blrnw3


Changes

Follow-up fix to #177. In addition to setting cache control headers (to avoid caching of result), we also needed to not cache the data in the server's own memory cache. Note that this server caching logic is being removed entirely in the Cache Redesign epic, but this PR removes it in one place to specifically fix the Seamless collection/dataset dropdown problems.

@atolopko-czi atolopko-czi self-assigned this Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #191 (9d47488) into main (4b1efff) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   71.71%   71.71%   -0.01%     
==========================================
  Files         126      126              
  Lines       10098    10096       -2     
==========================================
- Hits         7242     7240       -2     
  Misses       2856     2856              
Flag Coverage Δ
frontend 71.71% <90.90%> (-0.01%) ⬇️
javascript 71.71% <90.90%> (-0.01%) ⬇️
unitTest 71.71% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/data_common/dataset_metadata.py 91.66% <90.90%> (-0.12%) ⬇️
data_common/dataset_metadata.py 91.66% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b1efff...9d47488. Read the comment docs.

@atolopko-czi atolopko-czi merged commit ad4726c into main Nov 9, 2021
@atolopko-czi atolopko-czi deleted the atolopko/166-fix-seamless-caching branch November 9, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants