Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Check to SQL Update Statements to Avoid constraints on date_last_collected #2759

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

IsaacMilarky
Copy link
Contributor

@IsaacMilarky IsaacMilarky commented Apr 10, 2024

Description

  • There was a bug where tasks that had succeeded in the past but then subsequently fail later would not be reset correctly; running into a constraint on 'date_last_collected'
  • In response I have added checks to the date_last_collected field in order to prevent this issue
  • Specifically we now check for null values in the date field and update to either SUCCESS or PENDING depending on if the field is null or not.
  • The function now should reset the task to a state where it can be run again.

Signed commits

  • Yes, I signed my commits.

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins sgoggins merged commit 2474c56 into dev Apr 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants