Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback transaction when query throws exception #2777

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Rollback transaction when query throws exception #2777

merged 1 commit into from
Apr 28, 2024

Conversation

ABrain7710
Copy link
Contributor

Description

  • Rollback changes when a query using the session throws an exception so that the session can still be used

This PR fixes #

  • Issue where frontend doesn't work because the session fails on every query

Note: I don't care if this is merged into main or dev, I just noticed that dev is the same as main and this is a small fix so I opened it into main

Signed commits

  • Yes, I signed my commits.

Ulincsys
Ulincsys approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@Ulincsys Ulincsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sgoggins sgoggins merged commit eb97403 into main Apr 28, 2024
8 of 9 checks passed
@ABrain7710 ABrain7710 deleted the fix-session-rollback branch June 25, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ulincsys Ulincsys Ulincsys approved these changes

@sgoggins sgoggins sgoggins approved these changes

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ABrain7710 @sgoggins @Ulincsys