Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full collection for messages #2788

Merged
merged 1 commit into from
May 10, 2024
Merged

Add full collection for messages #2788

merged 1 commit into from
May 10, 2024

Conversation

ABrain7710
Copy link
Contributor

Signed commits

  • Yes, I signed my commits.

def retrieve_all_pr_and_issue_messages(repo_git: str, logger, key_auth, task_name) -> None:
result = session.query(CollectionStatus).filter(CollectionStatus.repo_id == repo_id, CollectionStatus.issue_pr_sum <= 10).first()

return result != None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0121: Comparison 'result != None' should be 'result is not None' (singleton-comparison)


if len(all_data) > 0:
process_messages(all_data, task_name, repo_id, logger, augur_db)


def process_messages(messages, task_name, repo_id, logger, augur_db):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R0914: Too many local variables (39/30) (too-many-locals)


if len(all_data) > 0:
process_messages(all_data, task_name, repo_id, logger, augur_db)


def process_messages(messages, task_name, repo_id, logger, augur_db):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R0912: Too many branches (18/12) (too-many-branches)


if len(all_data) > 0:
process_messages(all_data, task_name, repo_id, logger, augur_db)


def process_messages(messages, task_name, repo_id, logger, augur_db):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R0915: Too many statements (78/50) (too-many-statements)

@ABrain7710 ABrain7710 changed the base branch from main to dev May 10, 2024 16:02
@ABrain7710 ABrain7710 changed the base branch from dev to main May 10, 2024 16:02
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ABrain7710 !

@sgoggins sgoggins merged commit 8f0cb15 into main May 10, 2024
8 of 9 checks passed
@sgoggins sgoggins deleted the full-collect-messages branch June 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants