Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default arg values for rabbitmq dockerfile #2791

Merged
merged 1 commit into from
May 14, 2024
Merged

Add default arg values for rabbitmq dockerfile #2791

merged 1 commit into from
May 14, 2024

Conversation

Ulincsys
Copy link
Contributor

Description

  • Provide default values for the RabbitMQ dockerfile args so it will build by default

It is still recommended to pass values for production builds via --build-arg key=value

Signed commits

  • Yes, I signed my commits.

sgoggins
sgoggins approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins sgoggins merged commit dd05af9 into dev May 14, 2024
8 checks passed
@sgoggins sgoggins deleted the rabbit-mq-docker-fix branch June 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ulincsys @sgoggins