Debugging of `dev` branch looks complete #2810

sgoggins · 2024-06-05T02:43:38Z

Description

Field testing the fixes to the dev branch, and it looks good.
Ready to merge and release after this PR is merged with dev

Signed-off-by: Sean P. Goggins <[email protected]>

…t using a materialized view. Signed-off-by: Sean P. Goggins <[email protected]>

update check for pr_file_patch

Signed-off-by: Sean P. Goggins <[email protected]>

Signed-off-by: Andrew Brain <[email protected]>

Signed-off-by: Sean P. Goggins <[email protected]>

Signed-off-by: Sean Goggins <[email protected]>

Signed-off-by: Sean P. Goggins <[email protected]>

github-actions · 2024-06-05T02:44:15Z

augur/tasks/git/dependency_libyear_tasks/libyear_util/npm_libyear_utils.py

@@ -1,4 +1,7 @@
 import requests


[pylint] _{reported by reviewdog 🐶}
C0114: Missing module docstring (missing-module-docstring)

github-actions · 2024-06-05T02:44:15Z

augur/tasks/git/dependency_libyear_tasks/libyear_util/npm_libyear_utils.py

@@ -1,4 +1,7 @@
 import requests
+import logging 
+
+logger = logging.getLogger(__name__)

 def get_NPM_data(package):
    url = "https://registry.npmjs.org/%s" % package


[pylint] _{reported by reviewdog 🐶}
C0209: Formatting a regular string which could be an f-string (consider-using-f-string)

github-actions · 2024-06-05T02:44:15Z

augur/tasks/git/dependency_libyear_tasks/libyear_util/npm_libyear_utils.py

    try:
        index = list(versions.keys()).index(version)
    except ValueError as e:
+        logger.info(f'error is {e} on the NPM. Some kind of value error. Probably a VALUES error for Node, #AmIRight?')
        raise e

    major,minor,patch = split_version(version)


[pylint] _{reported by reviewdog 🐶}
W0612: Unused variable 'patch' (unused-variable)

github-actions · 2024-06-05T02:44:15Z

augur/tasks/github/messages/tasks.py

@@ -5,12 +5,12 @@
 from augur.tasks.init.celery_app import AugurCoreRepoCollectionTask
 from augur.application.db.data_parse import *


[pylint] _{reported by reviewdog 🐶}
W0401: Wildcard import augur.application.db.data_parse (wildcard-import)

github-actions · 2024-06-05T02:44:15Z

augur/tasks/github/messages/tasks.py

@@ -133,7 +133,7 @@ def process_large_issue_and_pr_message_collection(repo_id, repo_git: str, logger
        process_messages(all_data, task_name, repo_id, logger, augur_db)


-def process_messages(messages, task_name, repo_id, logger):
+def process_messages(messages, task_name, repo_id, logger, augur_db):


[pylint] _{reported by reviewdog 🐶}
R0914: Too many local variables (39/30) (too-many-locals)

github-actions · 2024-06-05T02:44:16Z

augur/tasks/start_tasks.py

    return request


-def build_facade_repo_collect_request(logger, enabled_phase_names, days_until_collect_again = 1):
+def build_facade_repo_collect_request(session, logger, enabled_phase_names, days_until_collect_again = 1):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'enabled_phase_names' (unused-argument)

github-actions · 2024-06-05T02:44:16Z

augur/tasks/start_tasks.py

    return request


-def build_facade_repo_collect_request(logger, enabled_phase_names, days_until_collect_again = 1):
+def build_facade_repo_collect_request(session, logger, enabled_phase_names, days_until_collect_again = 1):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'days_until_collect_again' (unused-argument)

github-actions · 2024-06-05T02:44:16Z

augur/tasks/start_tasks.py

    return request

-def build_ml_repo_collect_request(logger, enabled_phase_names, days_until_collect_again = 1):
+def build_ml_repo_collect_request(session, logger, enabled_phase_names, days_until_collect_again = 1):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'logger' (unused-argument)

github-actions · 2024-06-05T02:44:17Z

augur/tasks/start_tasks.py

    return request

-def build_ml_repo_collect_request(logger, enabled_phase_names, days_until_collect_again = 1):
+def build_ml_repo_collect_request(session, logger, enabled_phase_names, days_until_collect_again = 1):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'enabled_phase_names' (unused-argument)

github-actions · 2024-06-05T02:44:17Z

augur/tasks/start_tasks.py

    return request

-def build_ml_repo_collect_request(logger, enabled_phase_names, days_until_collect_again = 1):
+def build_ml_repo_collect_request(session, logger, enabled_phase_names, days_until_collect_again = 1):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'days_until_collect_again' (unused-argument)

…with admin on the repo for the platform to return anything. It never works out. Saving resources. Signed-off-by: Sean P. Goggins <[email protected]>

github-actions · 2024-06-05T03:24:32Z

augur/tasks/github/traffic/tasks.py

@@ -32,27 +32,27 @@ def collect_github_repo_clones_data(repo_git: str) -> None:
        logger.info(f"{owner}/{repo} has no clones")

 def retrieve_all_clones_data(repo_git: str, logger, key_auth):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'repo_git' (unused-argument)

github-actions · 2024-06-05T03:24:32Z

augur/tasks/github/traffic/tasks.py

@@ -32,27 +32,27 @@ def collect_github_repo_clones_data(repo_git: str) -> None:
        logger.info(f"{owner}/{repo} has no clones")

 def retrieve_all_clones_data(repo_git: str, logger, key_auth):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'logger' (unused-argument)

github-actions · 2024-06-05T03:24:32Z

augur/tasks/github/traffic/tasks.py

@@ -32,27 +32,27 @@ def collect_github_repo_clones_data(repo_git: str) -> None:
        logger.info(f"{owner}/{repo} has no clones")

 def retrieve_all_clones_data(repo_git: str, logger, key_auth):


[pylint] _{reported by reviewdog 🐶}
W0613: Unused argument 'key_auth' (unused-argument)

Signed-off-by: Sean Goggins <[email protected]>

Signed-off-by: Sean P. Goggins <[email protected]>

github-actions · 2024-06-05T15:26:17Z

augur/tasks/git/dependency_libyear_tasks/libyear_util/pypi_parser.py

+    #dependencies = contents['dependencies']
+    dependencies = contents.get('dependencies', [])
+
+    if not dependencies:


[pylint] _{reported by reviewdog 🐶}
R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)

github-actions · 2024-06-05T15:26:17Z

augur/tasks/git/dependency_libyear_tasks/libyear_util/pypi_parser.py

+        print("No dependencies found.")
+        return []
+    else:
+        print("Dependencies found.")
    for dep in dependencies:
        if (type(dep) is dict) and dep['pip']:


[pylint] _{reported by reviewdog 🐶}
C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)

…tasks/git/dependency_libyear_tasks/tasks.py,: cannot open `/home/sean/github/rh-k12/augur/tasks/git/dependency_libyear_tasks/tasks.py,' (No such file or directory) line: cannot open `line' (No such file or directory) 12,: cannot open `12,' (No such file or directory) in: cannot open `in' (No such file or directory) process_libyear_dependency_metrics: cannot open `process_libyear_dependency_metrics' (No such file or directory) Signed-off-by: Sean P. Goggins <[email protected]>

sgoggins and others added 30 commits May 10, 2024 19:51

update to materialized views testing scripts

bed9a5a

Signed-off-by: Sean P. Goggins <[email protected]>

Update build_docker.yml

5384e0f

Signed-off-by: Sean P. Goggins <[email protected]>

commented out the rebuilding of the dm_ tables. This should be rebuil…

16f6d6b

…t using a materialized view. Signed-off-by: Sean P. Goggins <[email protected]>

Merge pull request #2804 from chaoss/main

fcbb819

update check for pr_file_patch

checking pr file errors with more logging

2c8e856

Signed-off-by: Sean P. Goggins <[email protected]>

more debugging of pr files

04b9987

Signed-off-by: Sean P. Goggins <[email protected]>

update

8ad033f

Signed-off-by: Sean P. Goggins <[email protected]>

debugging files

d66bf45

Signed-off-by: Sean P. Goggins <[email protected]>

resorting to traceback

72b28a7

Signed-off-by: Sean P. Goggins <[email protected]>

fixing error

e13776c

Signed-off-by: Sean P. Goggins <[email protected]>

logging removeal

023477f

Signed-off-by: Sean P. Goggins <[email protected]>

use correct get active repo count

3de5ba9

Signed-off-by: Andrew Brain <[email protected]>

Pass correct thign

0c5d734

Signed-off-by: Andrew Brain <[email protected]>

Fix

2979091

Signed-off-by: Andrew Brain <[email protected]>

Pass DatabaseSession

f8217ed

Signed-off-by: Andrew Brain <[email protected]>

fixing scorecard

fc686e5

Signed-off-by: Sean P. Goggins <[email protected]>

fixing augur startup issue

7b914d7

Signed-off-by: Sean P. Goggins <[email protected]>

updated for facade repo out of sync error

e2217e5

Signed-off-by: Sean P. Goggins <[email protected]>

fixing dependency logic issue

c2ee07c

Signed-off-by: Sean P. Goggins <[email protected]>

node dependency checker

c3f4eaa

Signed-off-by: Sean P. Goggins <[email protected]>

version update

90b149c

Signed-off-by: Sean Goggins <[email protected]>

update

30b325d

Signed-off-by: Sean P. Goggins <[email protected]>

fixing

0f00cde

Signed-off-by: Sean P. Goggins <[email protected]>

fixing open ssf score card

e7d305d

Signed-off-by: Sean P. Goggins <[email protected]>

possibly fixed PR worker task

2d945ca

Signed-off-by: Sean P. Goggins <[email protected]>

fixing missing task manifest info

84b7fea

Signed-off-by: Sean P. Goggins <[email protected]>

fixing random key auth

f3002c1

Signed-off-by: Sean P. Goggins <[email protected]>

can you overload __init__ in Python?

6b2667a

Signed-off-by: Sean P. Goggins <[email protected]>

updating things

082d5d2

Signed-off-by: Sean P. Goggins <[email protected]>

trying a hack

6d25bd9

Signed-off-by: Sean P. Goggins <[email protected]>

sgoggins added 11 commits June 4, 2024 18:36

hacking

85e7b2d

Signed-off-by: Sean P. Goggins <[email protected]>

update

da9952b

Signed-off-by: Sean P. Goggins <[email protected]>

added Repo object

e69f65a

Signed-off-by: Sean P. Goggins <[email protected]>

messages fix

bf04ebc

Signed-off-by: Sean P. Goggins <[email protected]>

Merge remote-tracking branch 'origin/pr-file-patch' into dev-fixes

d8ccbba

update session

18ef774

Signed-off-by: Sean P. Goggins <[email protected]>

update for colelctionstatus

ad1bc2d

Signed-off-by: Sean P. Goggins <[email protected]>

fixing pr files

22312a7

Signed-off-by: Sean P. Goggins <[email protected]>

files model

2c4341d

Signed-off-by: Sean P. Goggins <[email protected]>

pr fix

8a97792

Signed-off-by: Sean P. Goggins <[email protected]>

update to message collection

b6adf94

Signed-off-by: Sean P. Goggins <[email protected]>

sgoggins requested a review from ABrain7710 June 5, 2024 02:43

sgoggins changed the base branch from main to dev June 5, 2024 02:44

github-actions bot reviewed Jun 5, 2024

View reviewed changes

we never get clones data so I commented it out. You need an API key …

7989c12

…with admin on the repo for the platform to return anything. It never works out. Saving resources. Signed-off-by: Sean P. Goggins <[email protected]>

github-actions bot reviewed Jun 5, 2024

View reviewed changes

sgoggins and others added 3 commits June 5, 2024 04:15

Updating version

33890da

Signed-off-by: Sean Goggins <[email protected]>

updated Dockerfile version info

ed6f5e1

Signed-off-by: Sean Goggins <[email protected]>

dependencies fix

7cb9d97

Signed-off-by: Sean P. Goggins <[email protected]>

github-actions bot reviewed Jun 5, 2024

View reviewed changes

sgoggins merged commit 6e5618d into dev Jun 7, 2024
7 checks passed

sgoggins deleted the dev-fixes branch June 11, 2024 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debugging of `dev` branch looks complete #2810

Debugging of `dev` branch looks complete #2810

sgoggins commented Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

github-actions bot Jun 5, 2024

		@@ -5,12 +5,12 @@
		from augur.tasks.init.celery_app import AugurCoreRepoCollectionTask
		from augur.application.db.data_parse import *

		@@ -32,27 +32,27 @@ def collect_github_repo_clones_data(repo_git: str) -> None:
		logger.info(f"{owner}/{repo} has no clones")

		def retrieve_all_clones_data(repo_git: str, logger, key_auth):

Debugging of dev branch looks complete #2810

Debugging of dev branch looks complete #2810

Conversation

sgoggins commented Jun 5, 2024

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

github-actions bot Jun 5, 2024

Choose a reason for hiding this comment

Debugging of `dev` branch looks complete #2810

Debugging of `dev` branch looks complete #2810