Startup wizard #2815
Startup wizard #2815
Conversation
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
… others that self resolve based on an end users version of Python3 now. Signed-off-by: sgoggins <[email protected]>
- Add ability to pass flags to `augur backend start` in compose - Add entrypoint for `AUGUR_TARGET=graphical` - Fix metadata import in compose environment - Improve Docker compatibility with startup wizard Signed-off-by: Ulincsys <[email protected]>
Improve profile page
Signed-off-by: Sean P. Goggins <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Merge Main into Dev
Dev to startup-wizard
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,3 +1 @@ | |||
| from .Environment import Environment | |||
| from .ServerThread import ServerThread | |||
| from .LoginException import LoginException | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
|
|
||
| for row in session.query(Config).all(): | ||
| data[row.section_name][row.setting_name] = row.value | ||
| except: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0702: No exception type(s) specified (bare-except)
| @@ -0,0 +1,2 @@ | |||
| from .Environment import Environment | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
| @@ -0,0 +1,297 @@ | |||
| from flask import Flask, request, session, render_template, url_for, redirect, send_file, Response | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)
| from functools import wraps | ||
| from pathlib import Path | ||
|
|
||
| import threading, json, subprocess, re, importlib.util, sys |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0410: Multiple imports on one line (threading, json, subprocess, re, importlib.util, sys) (multiple-imports)
| update_complete.acquire() | ||
| try: | ||
| update_complete.wait() | ||
| except KeyboardInterrupt as e: |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0612: Unused variable 'e' (unused-variable)
|
|
||
| print("First time setup exiting") | ||
|
|
||
| global do_continue |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0604: Using the global statement at the module level (global-at-module-level)
| augur = subprocess.Popen(f"augur backend start {env['AUGUR_FLAGS'] or ''}".split()) | ||
| augur.wait() | ||
| else: | ||
| subprocess.Popen(f"nohup augur backend start {env['AUGUR_FLAGS'] or ''}".split()) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
| from flask import Flask, request, session, render_template, url_for, redirect, send_file, Response | ||
| from sqlalchemy import MetaData, Table, create_engine | ||
| from bootstrap import ServerThread, Environment | ||
| from sqlalchemy.orm import Session |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0412: Imports from package sqlalchemy are not grouped (ungrouped-imports)
| global do_continue | ||
| if do_continue: | ||
| if env["AUGUR_DOCKER_DEPLOY"]: | ||
| augur = subprocess.Popen(f"augur backend start {env['AUGUR_FLAGS'] or ''}".split()) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
|
I made this a draft so we do not add it to the debugging stack on dev, which is pretty close to release. |
| @@ -23,7 +23,7 @@ jobs: | |||
| name: Build image | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Checkout main | |||
| - name: Checkout startup-wizard | |||
There was a problem hiding this comment.
IS this the branch we want people checking out forever on Docker?
| @@ -0,0 +1,18 @@ | |||
| name: Docker Image CI | |||
| @@ -160,7 +161,7 @@ def add_section(ctx, section_name, file): | |||
| @click.option('--section', required=True) | |||
| @click.option('--setting', required=True) | |||
| @click.option('--value', required=True) | |||
| @click.option('--data-type', required=True) | |||
| @click.option('--data-type') | |||
There was a problem hiding this comment.
Why would this not be required?
Requires extra attention before merge
Please carefully review changes in the following files, as I'm not sure they're correct:
.github/workflows/build_docker.yml.github/workflows/docker-image.ymlIt looks like this was merged previously, but is no longer in the dev branch. I'm re-opening the merge here to bring these changes to dev again.
Signed commits